Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documenting calling verify_jti callback with 2 arguments in the readme #402

Merged
merged 1 commit into from Feb 4, 2021

Conversation

@HoneyryderChuck
Copy link
Contributor

@HoneyryderChuck HoneyryderChuck commented Jan 25, 2021

Had to dive into the source code to find this one. Maybe the next one will not have to do the same.

@sourcelevel-bot
Copy link

@sourcelevel-bot sourcelevel-bot bot commented Jan 25, 2021

Hello, @HoneyryderChuck! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

README.md Show resolved Hide resolved
@anakinj
anakinj approved these changes Feb 4, 2021
README.md Show resolved Hide resolved
@anakinj anakinj merged commit 6ff11dc into jwt:master Feb 4, 2021
22 checks passed
22 checks passed
@github-actions
RuboCop
Details
@github-actions
test (2.3, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.3, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.3, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.1, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.2, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (ruby-head, true)
Details
@github-actions
test (truffleruby-head, true)
Details
codeclimate All good!
Details
@sourcelevel-bot
sourcelevel SourceLevel did not find any new or fixed issues.
Details
@anakinj
Copy link
Member

@anakinj anakinj commented Feb 4, 2021

Thanks @HoneyryderChuck. I was able to merge this as-is.

@HoneyryderChuck
Copy link
Contributor Author

@HoneyryderChuck HoneyryderChuck commented Feb 4, 2021

Thank you @anakinj !!

@HoneyryderChuck HoneyryderChuck deleted the HoneyryderChuck:verify-jti-docs branch Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants