Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document function and add tests for verify claims method #404

Conversation

@yasonk
Copy link
Contributor

@yasonk yasonk commented Feb 4, 2021

Had to dig through the code to find out how to disable verifications. Decided to add tests for the verify_claims method because it is the one using the options to determine which claims to verify.

@sourcelevel-bot
Copy link

@sourcelevel-bot sourcelevel-bot bot commented Feb 4, 2021

Hello, @yasonk! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@anakinj
anakinj approved these changes Feb 4, 2021
@anakinj anakinj merged commit 4fb9a2a into jwt:master Feb 4, 2021
22 checks passed
22 checks passed
@github-actions
RuboCop
Details
@github-actions
test (2.3, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.3, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.3, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.1, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.2, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (ruby-head, true)
Details
@github-actions
test (truffleruby-head, true)
Details
codeclimate All good!
Details
@sourcelevel-bot
sourcelevel SourceLevel did not find any new or fixed issues.
Details
@anakinj
Copy link
Member

@anakinj anakinj commented Feb 4, 2021

Looks great. Thanks @yasonk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants