Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appear: Missing Props #119

Closed
felixheck opened this issue Aug 20, 2018 · 15 comments
Closed

Appear: Missing Props #119

felixheck opened this issue Aug 20, 2018 · 15 comments
Labels
bug Something isn't working

Comments

@felixheck
Copy link

Hi there – just started with mdx-deck.
It's awesome, thanks!

But having some issues with using Appear.
As soon as use the component the following errors occur and the app breaks.

Warning: Failed prop type: The prop `slide` is marked as required in `Appear`, but its value is `null`.
Warning: Failed prop type: The prop `deck` is marked as required in `Appear`, but its value is `null`.

Haven't found any hint in the docs.


env
npm: 6.2.0
node: 10.9.0
@mdx-js/mdx: 0.15.0
mdx-deck: 1.6.4

@jxnblk
Copy link
Owner

jxnblk commented Aug 20, 2018

Those are just warnings, but is the app not working either?

@felixheck
Copy link
Author

There are some errors, I assumed those are due to the warnings. Anyway:

image

@felixheck
Copy link
Author

@jxnblk can you provide the source code of the demo? just to check if I'm doing anything wrong..

@jxnblk
Copy link
Owner

jxnblk commented Aug 25, 2018

What demo are you referring to? All the source code for this repo is in the repo...

@jxnblk jxnblk added the bug Something isn't working label Aug 25, 2018
@felixheck
Copy link
Author

felixheck commented Aug 26, 2018

found it.

@felixheck
Copy link
Author

felixheck commented Aug 26, 2018

The bug seems to occur when using mdx-deck even in the demo — it works when using ../dist (Sometimes). Really weird.

@jxnblk
Copy link
Owner

jxnblk commented Aug 28, 2018

I suspect that this might be related to a bug that #144 is attempting to fix. See also pomber/code-surfer#8

@felixheck
Copy link
Author

Yep, seems so

@jxnblk
Copy link
Owner

jxnblk commented Aug 29, 2018

Just published v1.7.0 – let me know if that resolves the issues you were seeing

@felixheck
Copy link
Author

image

:(

@jxnblk
Copy link
Owner

jxnblk commented Aug 30, 2018

Sorry, I’m really not sure what’s happening. Can you try rm -rf node_modules && npm i and try running it on a new mdx file with just a heading and no imports?

@felixheck
Copy link
Author

Well it works without the Appear component.
Even this minimal working example does not work:

https://gist.github.com/felixheck/7a2a41c53c07ff68a8eda79060cd713d

yamatatsu added a commit to yamatatsu/slides_2018-09-08_universal-domain that referenced this issue Sep 13, 2018
@felixheck
Copy link
Author

Works with v1.7.3 👌🏽🎉

@felixheck felixheck reopened this Oct 1, 2018
@felixheck
Copy link
Author

image

Getting the same errors again with several versions..

@jxnblk
Copy link
Owner

jxnblk commented Mar 23, 2019

Closing this since the internals for v2 are quite different and this should be resolved

@jxnblk jxnblk closed this as completed Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants