Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync to latest change stream tests #384

Merged
merged 1 commit into from Jul 10, 2020
Merged

Sync to latest change stream tests #384

merged 1 commit into from Jul 10, 2020

Conversation

jyemin
Copy link
Owner

@jyemin jyemin commented Jul 9, 2020

There is one behavioral change in these tests: to treat CursorNotFound errors as resumable.
The reason there is no corresponding change in the driver is because it was already doing this,
incorrectly it turns out. But now it turns it that it is the correct thing to do.

JAVA-3781
JAVA-3776

https://evergreen.mongodb.com/patch/5f078b0f3627e03cda405af4

@jyemin jyemin self-assigned this Jul 9, 2020
@jyemin jyemin requested a review from rozza July 9, 2020 21:24
There is one behavioral change in these tests: to treat CursorNotFound errors as resumable.
The reason there is no corresponding change in the driver is because it was already doing this,
incorrectly it turns out.  But now it turns it that it is the correct thing to do.

JAVA-3781
JAVA-3776
Copy link
Collaborator

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I like bugs that turn out to be correct!

@jyemin jyemin merged commit 674a404 into master Jul 10, 2020
@jyemin jyemin deleted the j3781 branch July 10, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants