Don't complete inside comments, which allows haskell-mode to complete pragmas #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pragmas If dante-company declines to perform completions, then subsequent company backends can take their turn. This includes the standard `company-capf` backend which checks `completion-at-point-functions`: haskell-mode provides such functions for completing LANGUAGE and other pragmas. This change makes Dante's company backend decline to complete inside comments, which tackles the specific case of pragma completion as requested in jyp#37 but without adding functionality to Dante itself. Dante should arguably not complete inside a string either, but I have not implemented that here. (One would check for `(nth 4 (syntax-ppss))`.)
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
dante-companydeclines to perform completions, then subsequent company backends can take their turn. This includes the standardcompany-capfbackend which checkscompletion-at-point-functions: haskell-mode provides such functions for completing LANGUAGE and otherpragmas.
This change makes Dante's company backend decline to complete inside comments, which tackles the specific case of pragma completion as requested in #37 but without adding functionality to Dante itself.
Dante should arguably not complete inside a string either, but I have not implemented that here. (One would check for
(nth 4 (syntax-ppss)).)