#2554 Fix test_classpathimporter fails on Windows #66

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@jamesmudd
Contributor

jamesmudd commented Mar 15, 2017

The issue here was the test relied on the cwd which is not set
consistently when running the tests in different ways.

#2554 Fix test_classpathimporter fails on Windows
The issue here was the test relied on the cwd which is not set
consistently when running the tests in different ways.
@jamesmudd

This comment has been minimized.

Show comment
Hide comment
@jamesmudd

jamesmudd Mar 15, 2017

Contributor

The name of the function test_support.DirsOnSysPath is a little misleading in this case its used to add jar files to the path. This change doesn't alter that just though maybe it should be renamed.

Contributor

jamesmudd commented Mar 15, 2017

The name of the function test_support.DirsOnSysPath is a little misleading in this case its used to add jar files to the path. This change doesn't alter that just though maybe it should be renamed.

darjus pushed a commit that referenced this pull request Mar 16, 2017

@Stewori

This comment has been minimized.

Show comment
Hide comment

@Stewori Stewori closed this Mar 16, 2017

@jamesmudd jamesmudd deleted the jamesmudd:2554 branch Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment