Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on line breaks between subject and body #17

Closed
markelog opened this issue Apr 24, 2014 · 2 comments
Closed

Warn on line breaks between subject and body #17

markelog opened this issue Apr 24, 2014 · 2 comments

Comments

@markelog
Copy link

See this commit as reference

markelog referenced this issue in jquery/jquery Apr 24, 2014
(cherry picked from commit 108428bcabb7027852ecd656b98f110a444039d0)
@scottgonzalez
Copy link
Contributor

I think what you're really asking for is all commits to have a trailing new line.

@jzaefferer
Copy link
Owner

I think Dave just didn't have commitplease installed (because it wouldn't install), otherwise it would have rejected the commit message. I just copied the message from jquery's git log and tried to use it, commitplease rejected it:

Invalid commit message, please fix the following issues:

- Second line must always be empty

Commit message was:

Build: Add "browser" keyword for npm
(cherry picked from commit 108428bcabb7027852ecd656b98f110a444039d0)
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
# On branch replace-symlink-with-copy
# Changes to be committed:
#   (use "git reset HEAD <file>..." to unstage)
#
#   new file:   foo
#   modified:   test.js
#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants