Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Improved translation for Turkish language #14

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

ergec commented Jan 16, 2013

  • Added translation for days after functionality in Turkish language
  • Added translation months and years in Turkish language for default functionality
@ergec ergec Improved translation for Turkish language
* Added translation for days after functionality in Turkish language
* Added translation months and years in Turkish language for default functionality
d480e81
Owner

jzaefferer commented Jan 24, 2013

Related to my comment on #13 - I'm considering importing the language files form moment.js (MIT licensed). Can you check if their turkish translation looks good to you? https://github.com/timrwood/moment/blob/master/lang/tr.js#L52

ergec commented Jan 25, 2013

Yes translations are ok but I noticed there is a slight problem with formatting dates. I'll report this to them too.

moment().format("MMM Do YY"); returns Jan 25th 13 for English which is ok but for Turkish it returns Oca 25'inci 13. We never read day with suffix. "Do MMMM YYYY" "MMMM Do YYYY" doesn't matter we read day as number 25 only, no suffix.

Contributor

Krinkle commented Jan 26, 2013

@jzaefferer Now that you mention it, momentjs. What value does jquery-prettydate provide over momentjs?

Looks like an opportunity to join forces, for the benefit of the user.

@jzaefferer jzaefferer referenced this pull request Jan 28, 2013

Closed

Adopt Moment.js? #15

Owner

jzaefferer commented May 31, 2013

@Krinkle momentjs has the same problem as this project: translations are user contributed, so there's only a limited selection, with usually no way for the maintainer to verify the quality of any contributions. I'd rather replace both projects with support for relative times in Globalize, with a modular build, on top of CLDR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment