Corrected Russian and added Ukrainian l10n + other changes #19

Closed
wants to merge 7 commits into from

2 participants

@Oire

Hi Jörn,

Here's what I've done:

  • Updated Russian localization according to my comment on its commit;
  • Added Ukrainian localization;
  • Updated French and Swedish localizations as they didn't contain messages for week, month, year and years;
  • Added support for the day before yesterday since this day is called in one word in many languages (cf. vorgestern in German). Updated localizations adding this message.
@jzaefferer
Owner

Thanks for the update. Introducing dayBeforeYesterday is interesting, though its not missing in all the other files that you didn't touch. Unlike the weeks/years fields (thanks for adding a few missing ones!), this can be easily fixed: Just use the days template if dayBeforeYesterday is missing. That will restore the current behaviour if the new template is missing.

@Oire

Fixed this.

However, I've got another issue (and, I guess, it requires more changes in the plugin itself): now it's March the 4th, 12:16 AM here. A comment in my blog posted on Saturday at night is reported as "Yesterday". However, it should be reporting "two days ago" (weil Sammstag schon vorgestern war - sorry others, it's better explained in German than in English).

Do you have a definite reason to use math.floor?

Thanks!

@jzaefferer
Owner

@Oire I have no idea why its using Math.floor. Could you check if there's any negative effects to removing/replacing that? Thanks.

@Oire
@jzaefferer
Owner

Great, thanks. One more thing, can you take a look at the jshint errors? Run grunt locally or look at the Travis build.

@Oire
@jzaefferer
Owner

Even if you don't run grunt/qunit, you can still just open the unit tests in the browser. With these changes in place, a lot of unit tests fail. Can you take a look at that?

@Oire

@jzaefferer, sorry but this "phantomjs timeout" is occurring even with your clean copy (I've cloned jzaefferer/jquery-prettydate in a safe folder).

Could you help, please?

@jzaefferer
Owner

Just open the unit tests in your browser, there's no need for PhantomJS.

Though if the timeouts still occur, try installing the latest version of PhantomJS. That usually helps. You can check which version you currently have with phantomjs --version.

@Oire

@jzaefferer, at last I've done it)

P.S. If a stupid guy like me would complain he doesn't see anything in the browser, just say to him "Hey guy, go and add the QUnit submodule!" — just in case there's another one in the world)

@jzaefferer
Owner

Thanks! Squashed and landed in 03650c9.

@jzaefferer jzaefferer closed this May 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment