Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure network type via grpc flags #1

merged 1 commit into from Nov 9, 2021


Copy link

@ecordell ecordell commented Nov 9, 2021

This also improves the logging on grpc and http startup

cobrautil.go Outdated
@@ -211,6 +211,7 @@ func RegisterGrpcServerFlags(flags *pflag.FlagSet, flagPrefix, serviceName, defa
defaultAddr = stringz.DefaultEmpty(defaultAddr, ":50051")

flags.String(flagPrefix+"-addr", defaultAddr, "address to listen on to serve "+serviceName)
flags.String(flagPrefix+"-network", "tcp", "network type to serve "+serviceName+ " (\"tcp\", \"tcp4\", \"tcp6\", \"unix\", \"unixpacket\")")
Copy link

@jzelinskie jzelinskie Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: a raw quote would shorten this line

this also improves the logging on grpc and http startup
@jzelinskie jzelinskie merged commit aabfbb3 into jzelinskie:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants