Incorporate the changes from @pahihu to support Java 11 and Java 17 #22
Comments
I disagree. The document gives additional information about the latest changes that were made to the CP language not a specific implementation of CP. On the contrary, it has much to do with GPCP as most, if not all, of those changes were implemented in GPCP. |
I disagree with you. If the changes were already implemented, that document is OK. But the fact is they are not yet implemented, that document only causes confusion to the users. |
Fact??? There seems to be some misunderstanding here. Which changes are you saying have not been implemented? |
See: pahihu/gpcp-JVM#2 That document is for another compiler. It doesn't apply to gpcp! |
pahihu/gpcp-JVM#2 has now been corrected at my request, confirming that the document does in fact apply to GPCP. |
|
@proberon Could you make a PR for this? It seems you are an enthusiast. |
|
Hi,
Since my repo is not forked from the original, making a PR from it is a bit problematic.
I have attached patch files, which contains the changes. Apply them in numerical order.
Regards,
Andras Pahi
… On 2023. Nov 24., at 10:10, tqo50396 ***@***.***> wrote:
@proberon <https://github.com/proberon> Could you make a PR for this? It seems you are an enthusiast.
—
Reply to this email directly, view it on GitHub <#22 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADTEB2Y5NY6UH3SOH2ENPPDYGBP6RAVCNFSM6AAAAAATS65C2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRVGM2TKMRYGY>.
You are receiving this because you were mentioned.
|
|
Hi Chris
I have suddenly become aware of this discussion thread.
I don’t really understand what the issues are, so perhaps you could find time to give me a short summary?
Regards
John
From: Chris Burrows ***@***.***>
Sent: Friday, January 6, 2023 11:26 PM
To: k-john-gough/gpcp ***@***.***>
Cc: K John Gough ***@***.***>; Mention ***@***.***>
Subject: Re: [k-john-gough/gpcp] Incorporate the changes from @pahihu to support Java 11 and Java 17 (Issue #22)
p/s: This commit should be skipped: ***@***.***<pahihu/gpcp-JVM@116c8c8> as that document has nothing to do with gpcp: pahihu/gpcp-JVM#2<pahihu/gpcp-JVM#2>
I disagree. The document gives additional information about the latest changes that were made to the CP language not a specific implementation of CP. On the contrary, it has much to do with GPCP as most, if not all, of those changes were implemented in GPCP.
—
Reply to this email directly, view it on GitHub<#22 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEC5EFAUMAFGT3ZXH7QAKSTWRAMNVANCNFSM6AAAAAATS65C2E>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
|
Hi John,
The part of this issue that you referred to is already closed:
pahihu/gpcp-JVM#2
I am not familiar with the JVM version of GPCP so am unable to help with that part of this issue,
Cheers,
Chris
|
I'm very glad to see @k-john-gough still around and accepting pull requests. @pahihu didn't fork from this repo, he populated his repo with the source code from the released zip archive. This make doing a pull request to incorporate his changes to this repo more difficult. I attempted to do only to realize I don't understand Java and know nothing about gpcp's internals. Anyone still around please consider making a pull request to incorporate @pahihu's changes. Thank you very much.
@proberon Please have a look at https://github.com/pahihu/gpcp-JVM, there are only 9 commits, but I don't understand anything to help. I don't want myself to create a mess for you all.
p/s: This commit should be skipped: pahihu/gpcp-JVM@116c8c8 as that document has nothing to do with gpcp: pahihu/gpcp-JVM#2
The text was updated successfully, but these errors were encountered: