feat(ssh): wire AddressFamily from sshconfig for IPv4/IPv6 selection#367
Merged
Conversation
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
There was a problem hiding this comment.
Pull request overview
This PR wires the AddressFamily setting from the internal sshconfig parsing into the SSH connection dial step, enabling IPv4-only (inet) or IPv6-only (inet6) outbound connections when establishing an SSH session.
Changes:
- Select
net.Dialernetwork astcp4whenAddressFamily=inet. - Select
net.Dialernetwork astcp6whenAddressFamily=inet6. - Keep default behavior as
tcp(coversany/unset), preserving dual-stack resolution and Happy Eyeballs behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kke
added a commit
that referenced
this pull request
Jun 3, 2026
…367) Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
added a commit
that referenced
this pull request
Jun 3, 2026
…367) Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
added a commit
that referenced
this pull request
Jun 4, 2026
…367) Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
added a commit
that referenced
this pull request
Jun 4, 2026
…367) Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
added a commit
that referenced
this pull request
Jun 4, 2026
…367) Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
added a commit
that referenced
this pull request
Jun 4, 2026
…367) Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
added a commit
that referenced
this pull request
Jun 4, 2026
…367) Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.