feat(ssh): wire sshconfig RekeyLimit bytes to RekeyThreshold#373
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR wires the parsed ssh_config RekeyLimit (bytes) setting into the underlying golang.org/x/crypto/ssh client configuration by setting ClientConfig.RekeyThreshold, and adds a unit test to validate the behavior.
Changes:
- Set
ssh.ClientConfig.RekeyThresholdfromc.sshConfig.RekeyLimit.MaxDatawhen configured. - Add a focused unit test to ensure
RekeyLimit.MaxDatais propagated into the client config.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
protocol/ssh/connection.go |
Maps sshconfig’s RekeyLimit.MaxData into x/crypto/ssh’s RekeyThreshold. |
protocol/ssh/connection_test.go |
Adds a unit test verifying RekeyThreshold is set from RekeyLimit.MaxData. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kke
force-pushed
the
ssh-config-rekey-limit
branch
from
23ddaa5 to
8604264
Compare
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
force-pushed
the
ssh-config-rekey-limit
branch
from
8604264 to
fba4fd6
Compare
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.