Use new APIs with k2.RaggedTensor #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will merge this PR after the following GitHub actions GitHub actions in icefall needs the latest k2 (v1.7) in order to pass all the checks (tests). |
csukuangfj
commented
Sep 8, 2021
| @@ -199,26 +198,25 @@ def get_texts(best_paths: k2.Fsa) -> List[List[int]]: | |||
| Returns a list of lists of int, containing the label sequences we | |||
| decoded. | |||
| """ | |||
| if isinstance(best_paths.aux_labels, k2.RaggedInt): | |||
| if isinstance(best_paths.aux_labels, k2.RaggedTensor): | |||
There was a problem hiding this comment.
Could you help to update k2 in ESPnet?
needs to be changed since there is no k2.RaggedInt and k2.RaggedFloat
in k2 v1.7.
There was a problem hiding this comment.
Also, we have to install k2 v1.7 in ESPnet GitHub actions.
|
Tests are passed, so merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires k2-fsa/k2#812
k2.RaggedTensoris introduced to replacek2.RaggedIntandk2.RaggedFloat. The code is not backward compatible.Also, you have to regenerate
HLG.pt.The advantages of usage
k2.RaggedTensorare that it is more Pythonic and functions about ragged tensors are easier to discover. (See https://k2-fsa.github.io/k2/python_api/index.html)