Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry not prefixed with k3d #1202

Open
lindhe opened this issue Jan 26, 2023 · 0 comments
Open

Registry not prefixed with k3d #1202

lindhe opened this issue Jan 26, 2023 · 0 comments

Comments

@lindhe
Copy link

lindhe commented Jan 26, 2023

When creating a new registry, it sometimes gets prefixed with k3d (i.e. DefaultObjectNamePrefix) and sometimes not. This inconsistency should be fixed for a better user experience.

Running the following creates a registry called k3d-foo:

k3d registry create foo --port 127.0.0.1:1234 

Running the following creates a registry called foo:

k3d cluster create --registry-create foo:127.0.0.1:1234

The comment here says that "DefaultObjectNamePrefix defines the name prefix for every object created by k3d", which is clearly not true.

Clearly, the registry is created without the prefix when using k3d cluster create --registry-create:

cfg.Registries.Create.Name = fvSplit[0]

Best would be if we could make DefaultObjectNamePrefix optional, because it can sometimes be nice to be able to override it (e.g. to create a local registry with the exact same name that a remote registry have).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant