From ca6030502d87aecee31870a10a41fb4e3c9b24f6 Mon Sep 17 00:00:00 2001 From: Kiernan Nicholls Date: Thu, 2 May 2024 21:46:36 -0400 Subject: [PATCH] Prepare for CRAN with new version and rhub --- .github/workflows/rhub.yaml | 95 +++++++++++++++++++++++++++++++++++++ DESCRIPTION | 2 +- NEWS.md | 5 ++ cran-comments.md | 5 ++ 4 files changed, 106 insertions(+), 1 deletion(-) create mode 100644 .github/workflows/rhub.yaml diff --git a/.github/workflows/rhub.yaml b/.github/workflows/rhub.yaml new file mode 100644 index 0000000..74ec7b0 --- /dev/null +++ b/.github/workflows/rhub.yaml @@ -0,0 +1,95 @@ +# R-hub's generic GitHub Actions workflow file. It's canonical location is at +# https://github.com/r-hub/actions/blob/v1/workflows/rhub.yaml +# You can update this file to a newer version using the rhub2 package: +# +# rhub::rhub_setup() +# +# It is unlikely that you need to modify this file manually. + +name: R-hub +run-name: "${{ github.event.inputs.id }}: ${{ github.event.inputs.name || format('Manually run by {0}', github.triggering_actor) }}" + +on: + workflow_dispatch: + inputs: + config: + description: 'A comma separated list of R-hub platforms to use.' + type: string + default: 'linux,windows,macos' + name: + description: 'Run name. You can leave this empty now.' + type: string + id: + description: 'Unique ID. You can leave this empty now.' + type: string + +jobs: + + setup: + runs-on: ubuntu-latest + outputs: + containers: ${{ steps.rhub-setup.outputs.containers }} + platforms: ${{ steps.rhub-setup.outputs.platforms }} + + steps: + # NO NEED TO CHECKOUT HERE + - uses: r-hub/actions/setup@v1 + with: + config: ${{ github.event.inputs.config }} + id: rhub-setup + + linux-containers: + needs: setup + if: ${{ needs.setup.outputs.containers != '[]' }} + runs-on: ubuntu-latest + name: ${{ matrix.config.label }} + strategy: + fail-fast: false + matrix: + config: ${{ fromJson(needs.setup.outputs.containers) }} + container: + image: ${{ matrix.config.container }} + + steps: + - uses: r-hub/actions/checkout@v1 + - uses: r-hub/actions/platform-info@v1 + with: + token: ${{ secrets.RHUB_TOKEN }} + job-config: ${{ matrix.config.job-config }} + - uses: r-hub/actions/setup-deps@v1 + with: + token: ${{ secrets.RHUB_TOKEN }} + job-config: ${{ matrix.config.job-config }} + - uses: r-hub/actions/run-check@v1 + with: + token: ${{ secrets.RHUB_TOKEN }} + job-config: ${{ matrix.config.job-config }} + + other-platforms: + needs: setup + if: ${{ needs.setup.outputs.platforms != '[]' }} + runs-on: ${{ matrix.config.os }} + name: ${{ matrix.config.label }} + strategy: + fail-fast: false + matrix: + config: ${{ fromJson(needs.setup.outputs.platforms) }} + + steps: + - uses: r-hub/actions/checkout@v1 + - uses: r-hub/actions/setup-r@v1 + with: + job-config: ${{ matrix.config.job-config }} + token: ${{ secrets.RHUB_TOKEN }} + - uses: r-hub/actions/platform-info@v1 + with: + token: ${{ secrets.RHUB_TOKEN }} + job-config: ${{ matrix.config.job-config }} + - uses: r-hub/actions/setup-deps@v1 + with: + job-config: ${{ matrix.config.job-config }} + token: ${{ secrets.RHUB_TOKEN }} + - uses: r-hub/actions/run-check@v1 + with: + job-config: ${{ matrix.config.job-config }} + token: ${{ secrets.RHUB_TOKEN }} diff --git a/DESCRIPTION b/DESCRIPTION index fc333ba..f04a59a 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: fflr Title: Retrieve ESPN Fantasy Football Data -Version: 2.2.4 +Version: 2.3.0 Authors@R: person("Kiernan", "Nicholls", email = "k5cents@gmail.com", role = c("aut", "cre", "cph"), comment = c(ORCID = "0000-0002-9229-7897")) diff --git a/NEWS.md b/NEWS.md index 6023e77..661675e 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,8 @@ +# fflr 2.3.0 + +* Update the package to work with the new API. +* Update examples and tests for post-season without data. + # fflr 2.2.4 Fix tests for post-season API data formats. diff --git a/cran-comments.md b/cran-comments.md index ceadc21..700c326 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -12,3 +12,8 @@ ## R CMD check results 0 errors | 0 warnings | 0 note + +## Submission + +* The package now fails gracefully with an informative message, returning a data +frame with zero rows that doesn't need to pass any tests.