New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to operator-sdk v1.5.0 #376
Comments
@ytsarev @k0da @somaritane |
@kuritka , are there any breaking changes that this osdk migration might introduce to k8gb behavior (~ public API)? |
it's about https://github.com/AbsaOSS/k8gb/blob/master/PROJECT#L9 i think |
@ytsarev , @somaritane oh I see, than v3 (viz following step) |
@ytsarev, @kuritka just to clarify, we're talking about osdk/kubebuilder project config version change from v3-alpha to 3, right? If yes, then it has nothing to do with k8gb versioning, unless it really brings breaking changes in k8gb project public API itself (ie if it causes breaking changes in glsb schema from user perspective), which we yet have to analyze. Only in this case that would be transition from v0.7.7 to v1.0.0 (incompatible API changes), but not to v3 Otherwise, it would be v0.7.7-> v0.8.0 (added functionality in a backwards compatible manner) |
@somaritane , I went through v1.4.0 and 1.5.0 upgrade. Having some build issues related to bumping controller-runtime. The version change I mentioned is related to file |
@kuritka thanks for clarification! 👍 |
close #376 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer) - v1.4.0 directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner. - v1.5.0 `PROJECT` config version `3-alpha1` must be upgraded to `"3"` - v1.5.0 Upgrade controller-runtime to v0.7.2 controller runtime. The package changed and controller must implement Reconciler interface. To be able to build project I had to implement interface (by adding context to Reconcile function) and use `client.Object` in handlers
close #376 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer) - v1.4.0 directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner. - v1.5.0 `PROJECT` config version `3-alpha1` must be upgraded to `"3"` - v1.5.0 Upgrade controller-runtime to v0.7.2 controller runtime. The package changed and controller must implement Reconciler interface. To be able to build project I had to implement interface (by adding context to Reconcile function) and use `client.Object` in handlers
close #376 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer) - v1.4.0 directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner. - v1.5.0 `PROJECT` config version `3-alpha1` must be upgraded to `"3"` - v1.5.0 Upgrade controller-runtime to v0.7.2 controller runtime. The package changed and controller must implement Reconciler interface. To be able to build project I had to implement interface (by adding context to Reconcile function) and use `client.Object` in handlers
close #376 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer) - v1.4.0 directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner. - v1.5.0 `PROJECT` config version `3-alpha1` must be upgraded to `"3"` - v1.5.0 Upgrade controller-runtime to v0.7.2 controller runtime. The package changed and controller must implement Reconciler interface. To be able to build project I had to implement interface (by adding context to Reconcile function) and use `client.Object` in handlers - test coverage
close #376 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer) - v1.4.0 directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner. - v1.5.0 `PROJECT` config version `3-alpha1` must be upgraded to `"3"` - v1.5.0 Upgrade controller-runtime to v0.7.2 controller runtime. The package changed and controller must implement Reconciler interface. To be able to build project I had to implement interface (by adding context to Reconcile function) and use `client.Object` in handlers - test coverage
close #376 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer) - v1.4.0 directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner. - v1.5.0 `PROJECT` config version `3-alpha1` must be upgraded to `"3"` - v1.5.0 Upgrade controller-runtime to v0.7.2 controller runtime. The package changed and controller must implement Reconciler interface. To be able to build project I had to implement interface (by adding context to Reconcile function) and use `client.Object` in handlers - test coverage
close #376 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer) - v1.4.0 directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner. - v1.5.0 `PROJECT` config version `3-alpha1` must be upgraded to `"3"` - v1.5.0 Upgrade controller-runtime to v0.7.2 controller runtime. The package changed and controller must implement Reconciler interface. To be able to build project I had to implement interface (by adding context to Reconcile function) and use `client.Object` in handlers - test coverage
close #376 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer) - v1.4.0 directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner. - v1.5.0 `PROJECT` config version `3-alpha1` must be upgraded to `"3"` - v1.5.0 Upgrade controller-runtime to v0.7.2 controller runtime. The package changed and controller must implement Reconciler interface. To be able to build project I had to implement interface (by adding context to Reconcile function) and use `client.Object` in handlers - test coverage
close #376 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer) - v1.4.0 directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner. - v1.5.0 `PROJECT` config version `3-alpha1` must be upgraded to `"3"` - v1.5.0 Upgrade controller-runtime to v0.7.2 controller runtime. The package changed and controller must implement Reconciler interface. To be able to build project I had to implement interface (by adding context to Reconcile function) and use `client.Object` in handlers - test coverage Signed-off-by: kuritka <kuritka@gmail.com>
close #376 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer) - v1.4.0 directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner. - v1.5.0 `PROJECT` config version `3-alpha1` must be upgraded to `"3"` - v1.5.0 Upgrade controller-runtime to v0.7.2 controller runtime. The package changed and controller must implement Reconciler interface. To be able to build project I had to implement interface (by adding context to Reconcile function) and use `client.Object` in handlers - test coverage Signed-off-by: kuritka <kuritka@gmail.com>
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.5.0/
The text was updated successfully, but these errors were encountered: