Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to operator-sdk v1.5.0 #376

Closed
ytsarev opened this issue Mar 18, 2021 · 7 comments · Fixed by #419
Closed

Upgrade to operator-sdk v1.5.0 #376

ytsarev opened this issue Mar 18, 2021 · 7 comments · Fixed by #419
Assignees
@kuritka
Labels
enhancement New feature or request
Milestone
0.8

Comments

@ytsarev
Copy link
Member

ytsarev commented Mar 18, 2021

https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.5.0/
@ytsarev ytsarev added the enhancement New feature or request label Mar 18, 2021
@ytsarev ytsarev added this to the 0.8 milestone Mar 18, 2021
@kuritka kuritka self-assigned this Mar 31, 2021
@kuritka
Copy link
Collaborator

kuritka commented Mar 31, 2021 •
edited

@ytsarev @k0da @somaritane
In order to migration Operator SDK v1.5.0: For Go-based operators, migrate your project to use the project version stable,
Should we release k8gb@v1.0.0 than ?

@somaritane
Copy link
Contributor

@kuritka , are there any breaking changes that this osdk migration might introduce to k8gb behavior (~ public API)?
If the answer is "no", then according to https://semver.org/ there's no need to bump major version of k8gb.

@ytsarev
Copy link
Member Author

ytsarev commented Mar 31, 2021

it's about https://github.com/AbsaOSS/k8gb/blob/master/PROJECT#L9 i think

@kuritka
Copy link
Collaborator

kuritka commented Mar 31, 2021 •
edited

@ytsarev , @somaritane oh I see, than v3 (viz following step)
thx for clarification!

@somaritane
Copy link
Contributor

@ytsarev , @somaritane oh I see, than v3 (viz following step)

@ytsarev, @kuritka just to clarify, we're talking about osdk/kubebuilder project config version change from v3-alpha to 3, right?

If yes, then it has nothing to do with k8gb versioning, unless it really brings breaking changes in k8gb project public API itself (ie if it causes breaking changes in glsb schema from user perspective), which we yet have to analyze.

Only in this case that would be transition from v0.7.7 to v1.0.0 (incompatible API changes), but not to v3

Otherwise, it would be v0.7.7-> v0.8.0 (added functionality in a backwards compatible manner)

@kuritka
Copy link
Collaborator

kuritka commented Mar 31, 2021 •
edited

@somaritane , I went through v1.4.0 and 1.5.0 upgrade. Having some build issues related to bumping controller-runtime.

The version change I mentioned is related to file PROJECT. No API changes; we go as planned v0.7.7-> v0.8.0

@somaritane
Copy link
Contributor

@kuritka thanks for clarification! 👍

kuritka added a commit that referenced this issue Mar 31, 2021
@kuritka
related to #376
e3f61bb
kuritka added a commit that referenced this issue Mar 31, 2021
@kuritka
Bump operator SDK to v1.5.0
98c6e0a 
close #376

 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer)
 - v1.4.0  directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner.
 - v1.5.0 `PROJECT` config version `3-alpha1`  must be upgraded to `"3"`
 - v1.5.0  Upgrade controller-runtime to v0.7.2 controller runtime.
The package changed and controller must implement Reconciler interface.
To be able to build project I had to implement interface (by adding context to Reconcile function)
and use `client.Object` in handlers
@kuritka kuritka mentioned this issue Mar 31, 2021
Merged
kuritka added a commit that referenced this issue Mar 31, 2021
@kuritka
Bump operator SDK to v1.5.0
72d26e6 
close #376

 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer)
 - v1.4.0  directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner.
 - v1.5.0 `PROJECT` config version `3-alpha1`  must be upgraded to `"3"`
 - v1.5.0  Upgrade controller-runtime to v0.7.2 controller runtime.
The package changed and controller must implement Reconciler interface.
To be able to build project I had to implement interface (by adding context to Reconcile function)
and use `client.Object` in handlers
kuritka added a commit that referenced this issue Mar 31, 2021
@kuritka
Bump operator SDK to v1.5.0
5aaa640 
close #376

 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer)
 - v1.4.0  directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner.
 - v1.5.0 `PROJECT` config version `3-alpha1`  must be upgraded to `"3"`
 - v1.5.0  Upgrade controller-runtime to v0.7.2 controller runtime.
The package changed and controller must implement Reconciler interface.
To be able to build project I had to implement interface (by adding context to Reconcile function)
and use `client.Object` in handlers
kuritka added a commit that referenced this issue Apr 1, 2021
@kuritka
Bump operator SDK to v1.5.0
c48cdfb 
close #376

 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer)
 - v1.4.0  directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner.
 - v1.5.0 `PROJECT` config version `3-alpha1`  must be upgraded to `"3"`
 - v1.5.0  Upgrade controller-runtime to v0.7.2 controller runtime.
The package changed and controller must implement Reconciler interface.
To be able to build project I had to implement interface (by adding context to Reconcile function)
and use `client.Object` in handlers
 - test coverage
kuritka added a commit that referenced this issue Apr 1, 2021
@kuritka
Bump operator SDK to v1.5.0
5e3225f 
close #376

 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer)
 - v1.4.0  directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner.
 - v1.5.0 `PROJECT` config version `3-alpha1`  must be upgraded to `"3"`
 - v1.5.0  Upgrade controller-runtime to v0.7.2 controller runtime.
The package changed and controller must implement Reconciler interface.
To be able to build project I had to implement interface (by adding context to Reconcile function)
and use `client.Object` in handlers
 - test coverage
kuritka added a commit that referenced this issue Apr 1, 2021
@kuritka
Bump operator SDK to v1.5.0
e3cf2bf 
close #376

 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer)
 - v1.4.0  directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner.
 - v1.5.0 `PROJECT` config version `3-alpha1`  must be upgraded to `"3"`
 - v1.5.0  Upgrade controller-runtime to v0.7.2 controller runtime.
The package changed and controller must implement Reconciler interface.
To be able to build project I had to implement interface (by adding context to Reconcile function)
and use `client.Object` in handlers
 - test coverage
kuritka added a commit that referenced this issue Apr 2, 2021
@kuritka
Bump operator SDK to v1.5.0
50764ed 
close #376

 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer)
 - v1.4.0  directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner.
 - v1.5.0 `PROJECT` config version `3-alpha1`  must be upgraded to `"3"`
 - v1.5.0  Upgrade controller-runtime to v0.7.2 controller runtime.
The package changed and controller must implement Reconciler interface.
To be able to build project I had to implement interface (by adding context to Reconcile function)
and use `client.Object` in handlers
 - test coverage
kuritka added a commit that referenced this issue Apr 9, 2021
@kuritka
Bump operator SDK to v1.5.0
5bde05e 
close #376

 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer)
 - v1.4.0  directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner.
 - v1.5.0 `PROJECT` config version `3-alpha1`  must be upgraded to `"3"`
 - v1.5.0  Upgrade controller-runtime to v0.7.2 controller runtime.
The package changed and controller must implement Reconciler interface.
To be able to build project I had to implement interface (by adding context to Reconcile function)
and use `client.Object` in handlers
 - test coverage
kuritka added a commit that referenced this issue Apr 9, 2021
@kuritka
Bump operator SDK to v1.5.0
3840d44 
close #376

 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer)
 - v1.4.0  directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner.
 - v1.5.0 `PROJECT` config version `3-alpha1`  must be upgraded to `"3"`
 - v1.5.0  Upgrade controller-runtime to v0.7.2 controller runtime.
The package changed and controller must implement Reconciler interface.
To be able to build project I had to implement interface (by adding context to Reconcile function)
and use `client.Object` in handlers
 - test coverage

Signed-off-by: kuritka <kuritka@gmail.com>
kuritka added a commit that referenced this issue Apr 9, 2021
@kuritka
Bump operator SDK to v1.5.0 (#419)
0cd23cf 
close #376

 - v1.4.0 Change operator's finalizer names (finalizer.cache.example.com should be changed to cache.example.com/finalizer)
 - v1.4.0  directory argument in docker-build was moved to the last position to align with podman's expectations, making substitution cleaner.
 - v1.5.0 `PROJECT` config version `3-alpha1`  must be upgraded to `"3"`
 - v1.5.0  Upgrade controller-runtime to v0.7.2 controller runtime.
The package changed and controller must implement Reconciler interface.
To be able to build project I had to implement interface (by adding context to Reconcile function)
and use `client.Object` in handlers
 - test coverage

Signed-off-by: kuritka <kuritka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuritka kuritka

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.8
Development

Successfully merging a pull request may close this issue.

Bump operator SDK to v1.5.0 k8gb-io/k8gb
3 participants
@somaritane @ytsarev @kuritka