Switch to coredns with DNSendpoint plugin #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0da
requested review from
donovanmuller,
kuritka,
somaritane and
ytsarev
as code owners
k0da
force-pushed
the
coredns_tune
branch
8 times, most recently
from
51f258c
to
3d92452
Compare
k0da
changed the title
kuritka
approved these changes
Feb 11, 2021
|
@ytsarev thoughts? |
|
|
kuritka
previously approved these changes
Feb 12, 2021
ytsarev
reviewed
Feb 21, 2021
| @@ -94,6 +94,7 @@ func (r *GslbReconciler) gslbDNSEndpoint(gslb *k8gbv1beta1.Gslb) (*externaldns.D | |||
| Name: gslb.Name, | |||
| Namespace: gslb.Namespace, | |||
| Annotations: map[string]string{"k8gb.absa.oss/dnstype": "local"}, | |||
| Labels: map[string]string{"k8gb.absa.oss/dnstype": "local"}, | |||
There was a problem hiding this comment.
Do we keep both labels and annotations?
There was a problem hiding this comment.
Yes for backward compatibilty.
|
@ytsarev terratest brings coredns up, terratest runs dig against Change isn't huge. We just cutted of ETCD as medium for CoreDNS and use DNSEndpoint object directly. |
* put dnstype as label * Drop etcd, internal extdns instance, and coredns with etcd plugin * Use CoreDNS with DNSEndpoint plugin Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
k0da
force-pushed
the
coredns_tune
branch
2 times, most recently
from
7a0701c
to
cb79e1e
Compare
|
@k0da could you point me to the tests you are talking about? |
|
@k0da so pretty much existing regression test suite. Ok, it makes sense |
ytsarev
approved these changes
Feb 22, 2021
kuritka
approved these changes
Feb 22, 2021
somaritane
approved these changes
Feb 22, 2021
Closed
k0da
referenced
this pull request
Feb 28, 2021
During CoreDNS refactor https://github.com/AbsaOSS/k8gb/pull/292 local external-dns instance was removed, while Route53 and NS1 external-dns instances relies on service account created by local instance. This commit brings back external-dns service account. Fixes: https://github.com/AbsaOSS/k8gb/issues/328 Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
ytsarev
referenced
this pull request
Mar 1, 2021
During CoreDNS refactor https://github.com/AbsaOSS/k8gb/pull/292 local external-dns instance was removed, while Route53 and NS1 external-dns instances relies on service account created by local instance. This commit brings back external-dns service account. Fixes: https://github.com/AbsaOSS/k8gb/issues/328 Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
k0da
referenced
this pull request
Mar 1, 2021
* Bring back external-dns service account During CoreDNS refactor https://github.com/AbsaOSS/k8gb/pull/292 local external-dns instance was removed, while Route53 and NS1 external-dns instances relies on service account created by local instance. This commit brings back external-dns service account. Fixes: https://github.com/AbsaOSS/k8gb/issues/328 Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa> * Add missing RBAC for external-dns Signed-off-by: Yury Tsarev <yury.tsarev@absa.africa> Co-authored-by: Yury Tsarev <yury.tsarev@absa.africa>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dinar Valeev dinar.valeev@absa.africa