Pass endpoint params for ns1 external-dns provider #470
Conversation
k0da
requested review from
donovanmuller,
kuritka,
somaritane and
ytsarev
as code owners
| ns1: | ||
| enabled: true | ||
| # endpoint: https://ns1.example.com | ||
| # ignoreSSL: false |
There was a problem hiding this comment.
ignoreSSL can stay false uncommented
There was a problem hiding this comment.
This way it will be set into deployment, which makes args list longer and hard to read. I'd leave defaults into provider's default settings
There was a problem hiding this comment.
No, in case of false the if in the template will not add the parameter at all
There was a problem hiding this comment.
Sorry, missed that you referenced example values, while I've been amending default chart values. Fixed now
chart/k8gb/values.yaml
Outdated
|
|
||
| ns1: | ||
| enabled: false | ||
| # endpoint: http://ns1.example.com |
There was a problem hiding this comment.
please mentioned in the comment that the value is optional and it defaults to managed NS1
k0da
force-pushed
the
ns1
branch
2 times, most recently
from
14bccab to
de2e682
Compare
| ns1: | ||
| enabled: true | ||
| # endpoint: https://ns1.example.com | ||
| # ignoreSSL: false |
depends on the default. If it is higher than our 30sec we might need to override it. Overall, the collision with DNSEndpoint CR does not look convenient. I am not sure about behavior here at all btw - will minTTL override specific CR TTL value? Does it have precedence? We need to figure out. Anyway, it does not block this specific PR |
|
|
||
| ns1: | ||
| enabled: true | ||
| # endpoint: https://ns1.example.com |
There was a problem hiding this comment.
why do we need it in this sample?
|
|
||
| ns1: | ||
| enabled: true | ||
| # endpoint: https://ns1.example.com |
Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
Signed-off-by: Dinar Valeev dinar.valeev@absa.africa