Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't evaluate COREDNS IP too early #772

Merged
merged 1 commit into from Nov 25, 2021
Merged

Don't evaluate COREDNS IP too early #772

merged 1 commit into from Nov 25, 2021

Conversation

k0da
Copy link
Collaborator

@k0da k0da commented Nov 25, 2021

kubectl context is not yet established during initialization. Revert
K8GB_COREDNS_IP to command to be executed rather than commands result.

Fixes #770

Signed-off-by: Dinar Valeev dinar.valeev@absa.africa

kubectl context is not yet established during initialization. Revert
K8GB_COREDNS_IP to command to be executed rather than commands result.

Fixes k8gb-io#770

Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
@k0da
Copy link
Collaborator Author

k0da commented Nov 25, 2021

☸ k3d-test-gslb2 in k8gb on  make [$!?] via 🐹 v1.17.1
22:17:33 ❯ /usr/bin/make
check                     Check project integrity
demo                      Execute end-to-end demo
deploy-full-local-setup   Deploy full local multicluster setup (k3d >= 4.2.0)
deploy-gslb-operator      Deploy k8gb operator
deploy-test-apps          Deploy Podinfo (example app) and Apply Gslb Custom Resources
deploy-test-version       Upgrade k8gb to the test version on existing clusters
destroy-full-local-setup  Destroy full local multicluster setup
dns-tools                 Run temporary dnstools pod for debugging DNS issues
help                      Show this help

☸ k3d-test-gslb2 in k8gb on  make [$!?] via 🐹 v1.17.1
22:17:38 ❯ make test-round-robin
{
  "hostname": "frontend-podinfo-7579d54897-pl96f",
  "version": "5.1.1",
  "revision": "",
  "color": "#34577c",
  "logo": "https://raw.githubusercontent.com/stefanprodan/podinfo/gh-pages/cuddle_clap.gif",
  "message": "us",
  "goos": "linux",
  "goarch": "amd64",
  "runtime": "go1.15.6",
  "num_goroutine": "8",
  "num_cpu": "6"
}pod "busybox" deleted

Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@k0da k0da merged commit cc51976 into k8gb-io:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: make command errors
3 participants