Prometheus on emptyDir volumes #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
jkremser
requested review from
donovanmuller,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
|
✔️ Deploy Preview for k8gb-preview ready! 🔨 Explore the source changes: 53a37bd 🔍 Inspect the deploy log: https://app.netlify.com/sites/k8gb-preview/deploys/61b727ec3a000b00079fd2f4 😎 Browse the preview: https://deploy-preview-798--k8gb-preview.netlify.app/contributing |
ytsarev
previously approved these changes
Dec 13, 2021
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
jkremser
force-pushed
the
prometheus-pvc
branch
from
a3567d6
to
53a37bd
Compare
|
pls one more round, I changed "data are" -> "data is" (and only then learned that both are actually fine) |
k0da
approved these changes
Dec 13, 2021
somaritane
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More light-weight approach that doesn't require persistent volumes. On the other hand all the data is ephemeral.
Signed-off-by: Jirka Kremser jiri.kremser@gmail.com