Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use the manager client in tests #42

Closed
jsanda opened this issue Apr 8, 2021 · 1 comment · May be fixed by #43
Closed

Do not use the manager client in tests #42

jsanda opened this issue Apr 8, 2021 · 1 comment · May be fixed by #43
Assignees
@burmanm
Labels
complexity: medium enhancement New feature or request needs-triage sprint: 3 sprint: 4 sprint: 5 sprint: 6

Comments

@jsanda
Copy link
Contributor

jsanda commented Apr 8, 2021 •
edited by sync-by-unito bot
Loading

We are using the manager client in tests which is the same client used by controllers. It reads from caches which means it is not strongly consistent. In tests we usually want strong consistency where the client will read directly from the api server.

burmanm pointed out kubernetes-sigs/kubebuilder#2066 to me which discusses this.

┆Issue is synchronized with this Jira Task by Unito
┆Reviewer: Michael Burman
┆friendlyId: K8SSAND-144
┆priority: Medium
@jsanda jsanda added enhancement New feature or request needs-triage labels Apr 8, 2021
@jsanda jsanda self-assigned this Apr 8, 2021
@jsanda jsanda mentioned this issue Apr 8, 2021
Open
@burmanm burmanm self-assigned this Apr 19, 2021
@adejanovski adejanovski added zh:Review Issues in the ZenHub pipeline 'Review' and removed zh:In-Progress labels Apr 29, 2022
@jsanda
Copy link
Contributor Author

jsanda commented May 10, 2022

Closing as this is no longer relevant

@jsanda jsanda closed this as completed May 10, 2022
@adejanovski adejanovski removed the zh:Review Issues in the ZenHub pipeline 'Review' label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@burmanm burmanm

Labels
complexity: medium enhancement New feature or request needs-triage sprint: 3 sprint: 4 sprint: 5 sprint: 6
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use client.New for tests to get consistent reads [K8SSAND-144] jsanda/reaper-operator
4 participants
@jsanda @burmanm @adejanovski @jdonenine