Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple blacklist spam filter #148

Closed
wants to merge 8 commits into from

Conversation

@Yogu
Copy link

Yogu commented May 15, 2012

If the IMAP server does not provide a spam filter, there is currently no way to avoid continuous notifications when spam arrives. To solve this problem, I implemented a simple blacklist-based spam filter extension to K-9.

Shortly after I posted this extension on my website, I received eleven visits coming from a google search for "k-9 spam filter", so I think this feature is requested by users.

The filter is disabled by default and can be enabled in the account options. If enabled, mails moved to the spam folder are declared as spam and their sender addresses are added to the blacklist. On the other hand, mails moved out from the spam folder to another location are assumed not to be spam; their sender address is removed from the blacklist. The blacklist can be easily edited in the account preferences.

Currently, the preferences are only translated into German and English.

@cketti

This comment has been minimized.

Copy link
Member

cketti commented May 16, 2012

Hi,

I like the idea of a simple blacklist. But using the preference storage to save the blacklisted addresses is a very bad idea and doesn't scale very well. They should be stored in a separate database table.
Also, the user interface to view/modify the list of blacklisted email addresses should probably use a ListView, not a simple EditText widget.

If you are willing to make the necessary changes I am more than happy to tell you what exactly I have in mind and answer any questions you might have. We can discuss this on the developer mailing list (https://groups.google.com/group/k-9-dev), on IRC (#k-9, Freenode) where many of the K-9 developers can be found, or you can reach me via email (cketti [at] Gmail, German is fine).

-cketti

@Yogu

This comment has been minimized.

Copy link
Author

Yogu commented May 18, 2012

Hi cketti,

I openend a thread in google groups: https://groups.google.com/forum/?fromgroups#!topic/k-9-dev/U9XYbv8e5SA

Yogu

Yogu added 7 commits Jul 22, 2012
Conflicts:
	AndroidManifest.xml
	src/com/fsck/k9/controller/MessagingController.java
Conflicts:
	AndroidManifest.xml
	src/com/fsck/k9/Account.java
	src/com/fsck/k9/activity/setup/AccountSettings.java
	src/com/fsck/k9/preferences/Settings.java
@cketti cketti force-pushed the k9mail:master branch from 89ef72a to a10b9ae Sep 10, 2014
@cketti

This comment has been minimized.

Copy link
Member

cketti commented Jun 10, 2015

Closing this PR because we want a different implementation. Created issue #679 to track the feature.

@cketti cketti closed this Jun 10, 2015
@philipwhiuk philipwhiuk mentioned this pull request May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.