Call storeSmallMessage in one transaction context #53

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

andrewgaul commented Sep 30, 2011

Benchmarking listing and fetching 24 small messages over Wifi improves
from 35 to 17 seconds on a Samsung Galaxy S running Android 2.2.
Partially addresses issue 2245.

@andrewgaul andrewgaul Call storeSmallMessage in one transaction context
Benchmarking listing and fetching 24 small messages over Wifi improves
from 35 to 17 seconds on a Samsung Galaxy S running Android 2.2.
Partially addresses issue 2245.
e4a8a3c
Owner

obra commented Oct 1, 2011

Hi Andrew,

We've discussed this some on IRC (Feel free to join us on #k-9 on freenode)

Doing this as a single transaction can result in some pretty painful blocking in the case of a very large/long sync. Would you be up for redoing it to batch into bundles of 5-10 messages?

Best,
Jesse

On Sep 30, 2011, at 1:06 AM, Andrew Gaul wrote:

Benchmarking listing and fetching 24 small messages over Wifi improves
from 35 to 17 seconds on a Samsung Galaxy S running Android 2.2.
Partially addresses issue 2245.

You can merge this Pull Request by running:

git pull https://github.com/andrewgaul/k-9 store-small-messages-in-one-transaction

Or you can view, comment on it, or merge it online at:

#53

-- Commit Summary --

  • Call storeSmallMessage in one transaction context

-- File Changes --

M src/com/fsck/k9/controller/MessagingController.java (126)
M src/com/fsck/k9/mail/store/LocalStore.java (17)

-- Patch Links --

https://github.com/k9mail/k-9/pull/53.patch
https://github.com/k9mail/k-9/pull/53.diff

Reply to this email directly or view it on GitHub:
#53

Contributor

andrewgaul commented Oct 3, 2011

Thank you for your feedback. I did not consider interactivity and will address your suggestion in a subsequent patch. I have some more ideas on how to address the symptoms of issue 2245 and suspect it will involve several patches over the coming weeks. I will drop by #k-9 and introduce myself as time permits.

Owner

obra commented Apr 7, 2012

Andrew, I'm closing this pull request, since it sounds like we all agreed to solve the issue differently. I hope all is well with you -J

obra closed this Apr 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment