linkify relevant URI types: bitcoin, bridge, market, openpgp4fpr, xmpp #684
Conversation
|
I think it would be a good idea to only linkify those if the relevant app is installed (IOW, the intent for those URIs is resolvable). |
This expands the linkifying in the message view to include some relevant and common URI schemes. This makes all of the regexps compiled once at start time, to prevent them from being recompiled each time a new email is viewed. Here are some example URIs that work: bitcoin:175tWpb8K1S7NmH4Zx6rewF9WQrcZv245W geo:34.99393,-106.61568 openpgp4fpr:5E61C8780F86295CE17D86779F0FE587374BBE81 openpgp4fpr:9F0FE587374BBE81 openpgp4fpr:374BBE81 market://details?id=info.guardianproject.checkey market://details?id=com.fsck.k9 xmpp:to@foo.com?subscribe;otr-fingerprint=98273491287349817243987124 xmpp:gptest@xmpp.jp xmpp://gptest@xmpp.jp xmpp:gptest@jabber.ccc.de?subscribe;otr-fingerprint=DC45EB0B00CD76D05C327C9143B4025697413ED6 Here are some examples of wrong URIs that should not work: openpgp4fpr:374BBE8 market:details?id=info.guardianproject.checkey
In order to prevent pointlessly confusing linkifying in the message body, K-9 should only linkify special links (i.e. non-HTTP) if there is an app installed that can handle that URI scheme. This happens in onResume() in both MessageList and MessageCompose so that the info is reasonably current when the linkifying happens.
|
@maniac103 good idea, I updated this pull request to do just that. |
|
The issue with the OsmAnd URLs is solved now. Location sharing works with the osmand.net link. Now I'm curious for the next K-9 update, if the geo: URI will be clickable too. |
|
I would move this code into a new class + tests are missing |
|
I created issue #2265 to keep track of this feature. It also contains some notes about how I'd like this to be implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This expands the linkifying in the message view to include some relevant
and common URI schemes.
This makes all of the regexps compiled once at start time, to prevent them
from being recompiled each time a new email is viewed.
Here are some example URIs that work:
openpgp4fpr:5E61C8780F86295CE17D86779F0FE587374BBE81
openpgp4fpr:9F0FE587374BBE81
openpgp4fpr:374BBE81
market://details?id=info.guardianproject.checkey
market://details?id=com.fsck.k9
xmpp:to@foo.com?subscribe;otr-fingerprint=98273491287349817243987124
xmpp:gptest@xmpp.jp
xmpp://gptest@xmpp.jp
xmpp:gptest@jabber.ccc.de?subscribe;otr-fingerprint=DC45EB0B00CD76D05C327C9143B4025697413ED6
Here are some examples of wrong URIs that should not work:
openpgp4fpr:374BBE8
market:details?id=info.guardianproject.checkey
The text was updated successfully, but these errors were encountered: