New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attachment upload #6

Merged
merged 2 commits into from Dec 20, 2012

Conversation

Projects
None yet
3 participants
@nberger

nberger commented Dec 20, 2012

Fixes two errors on attachment upload:

NoMethodError (undefined method `container' for nil:NilClass):
plugins/redmine_s3/lib/redmine_s3/attachments_controller_patch.rb:20:in `redirect_to_s3'

and

NoMethodError (undefined method `read' for #<String:0x00000005d84190>):
app/controllers/attachments_controller.rb:88:in `upload'
@ka8725

This comment has been minimized.

Owner

ka8725 commented Dec 20, 2012

What was a problem? Please, explain why did you make these changes

@@ -7,7 +7,7 @@ def self.included(base) # :nodoc:
# Same as typing in the class
base.class_eval do
unloadable # Send unloadable so it will not be unloaded in development
before_filter :redirect_to_s3, :except => :destroy
before_filter :redirect_to_s3, :except => [:destroy, :upload]

This comment has been minimized.

@nberger

nberger Dec 20, 2012

Fixes:

NoMethodError (undefined method `container' for nil:NilClass):
plugins/redmine_s3/lib/redmine_s3/attachments_controller_patch.rb:20:in `redirect_to_s3'

redirect_to_s3 is intended to redirect the download of files to S3. It should not run while uploading. :destroy action was already being skipped, so I added :upload into the :except list

@@ -20,7 +20,8 @@ module InstanceMethods
def put_to_s3
if @temp_file && (@temp_file.size > 0)
logger.debug("Uploading to #{disk_filename}")
RedmineS3::Connection.put(disk_filename, @temp_file.read)
content = @temp_file.respond_to?(:read) ? @temp_file.read : @temp_file

This comment has been minimized.

@nberger

nberger Dec 20, 2012

Fixes:

NoMethodError (undefined method `read' for #<String:0x00000005d84190>):
app/controllers/attachments_controller.rb:88:in `upload'

Not sure why, but I was getting a String instead of a File in @temp_file. @temp_file#read should not be called in this case. Redmine already accounts for this: https://github.com/redmine/redmine/blob/master/app/models/attachment.rb#L112-L117. I did the same as in redmine master, calling @temp_file.read only if @temp_file.respond_to?(:read)

@ka8725

This comment has been minimized.

Owner

ka8725 commented Dec 20, 2012

Ok, thank you! Perfect!

ka8725 added a commit that referenced this pull request Dec 20, 2012

@ka8725 ka8725 merged commit 81a3647 into ka8725:master Dec 20, 2012

@morytox

This comment has been minimized.

morytox commented Feb 22, 2013

I See that

NoMethodError (undefined method container' for nil:NilClass): plugins/redmine_s3/lib/redmine_s3/attachments_controller_patch.rb:20:inredirect_to_s3'

was fixed and merged. I use that current version but the error is still there.
I Get this error when i try to access this file.

Any hints ?

@ka8725

This comment has been minimized.

Owner

ka8725 commented Feb 22, 2013

Explain what you do step by step

@morytox

This comment has been minimized.

morytox commented Feb 22, 2013

so i try to run it on a similar structure like heroku (cloudControl).
I followed your installation guide. And it is working.
I am uploading files in some tickets in the tool. Checked if they arrived on S3, they did.
When i Klick the attachment link (probably 4 download) i get an Errorpage:

Internal error

An error occurred on the page you were trying to access.
If you continue to experience problems please contact your Easy Redmine administrator for assistance.

If you are the Easy Redmine administrator, check your log files ([easy_redmine_app]/log/production.log) for details about the error. If you cannot repair it send the log to support@easyredmine.com with error description.

I checked the Errorlog and got following:

[Fri Feb 22 11:56:00 2013] info Started GET "/attachments/4/1a.csv?version=true" for 178.19.208.122 at 2013-02-22 11:56:00 +0000
[Fri Feb 22 11:56:00 2013] info Processing by AttachmentsController#show as HTML
[Fri Feb 22 11:56:00 2013] info   Parameters: {"version"=>"true", "id"=>"4", "filename"=>"1a.csv"}
[Fri Feb 22 11:56:00 2013] info   Current user: xyz (id=21)
[Fri Feb 22 11:56:00 2013] info Completed 500 Internal Server Error in 6ms
[Fri Feb 22 11:56:00 2013] info 
[Fri Feb 22 11:56:00 2013] info NoMethodError (undefined method `container' for nil:NilClass):
[Fri Feb 22 11:56:00 2013] info   plugins/redmine_s3/lib/redmine_s3/attachments_controller_patch.rb:20:in `redirect_to_s3'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:462:in `_run__2121466599716767340__process_action__3178821408640399483__callbacks'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:405:in `__run_callback'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:385:in `_run_process_action_callbacks'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:81:in `run_callbacks'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/abstract_controller/callbacks.rb:17:in `process_action'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_controller/metal/rescue.rb:29:in `process_action'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_controller/metal/instrumentation.rb:30:in `block in process_action'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activesupport-3.2.11/lib/active_support/notifications.rb:123:in `block in instrument'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activesupport-3.2.11/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activesupport-3.2.11/lib/active_support/notifications.rb:123:in `instrument'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_controller/metal/instrumentation.rb:29:in `process_action'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_controller/metal/params_wrapper.rb:207:in `process_action'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activerecord-3.2.11/lib/active_record/railties/controller_runtime.rb:18:in `process_action'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/newrelic_rpm-3.5.7.59/lib/new_relic/agent/instrumentation/rails3/action_controller.rb:34:in `block in process_action'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/newrelic_rpm-3.5.7.59/lib/new_relic/agent/instrumentation/controller_instrumentation.rb:268:in `block in perform_action_with_newrelic_trace'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/newrelic_rpm-3.5.7.59/lib/new_relic/agent/method_tracer.rb:240:in `trace_execution_scoped'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/newrelic_rpm-3.5.7.59/lib/new_relic/agent/instrumentation/controller_instrumentation.rb:263:in `perform_action_with_newrelic_trace'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/newrelic_rpm-3.5.7.59/lib/new_relic/agent/instrumentation/rails3/action_controller.rb:33:in `process_action'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/abstract_controller/base.rb:121:in `process'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/abstract_controller/rendering.rb:45:in `process'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_controller/metal.rb:203:in `dispatch'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_controller/metal/rack_delegation.rb:14:in `dispatch'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_controller/metal.rb:246:in `block in action'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/routing/route_set.rb:73:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/routing/route_set.rb:73:in `dispatch'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/routing/route_set.rb:36:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/journey-1.0.4/lib/journey/router.rb:68:in `block in call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/journey-1.0.4/lib/journey/router.rb:56:in `each'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/journey-1.0.4/lib/journey/router.rb:56:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/routing/route_set.rb:601:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/rack-openid-1.3.1/lib/rack/openid.rb:98:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/newrelic_rpm-3.5.7.59/lib/new_relic/rack/error_collector.rb:8:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/newrelic_rpm-3.5.7.59/lib/new_relic/rack/agent_hooks.rb:14:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/newrelic_rpm-3.5.7.59/lib/new_relic/rack/browser_monitoring.rb:12:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/middleware/best_standards_support.rb:17:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/rack-1.4.5/lib/rack/etag.rb:23:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/rack-1.4.5/lib/rack/conditionalget.rb:25:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/middleware/head.rb:14:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/middleware/params_parser.rb:21:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/middleware/flash.rb:242:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/rack-1.4.5/lib/rack/session/abstract/id.rb:210:in `context'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/rack-1.4.5/lib/rack/session/abstract/id.rb:205:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/middleware/cookies.rb:341:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activerecord-3.2.11/lib/active_record/query_cache.rb:64:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activerecord-3.2.11/lib/active_record/connection_adapters/abstract/connection_pool.rb:479:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/middleware/callbacks.rb:28:in `block in call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:405:in `_run__4280140219931174511__call__58588421483399845__callbacks'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:405:in `__run_callback'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:385:in `_run_call_callbacks'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:81:in `run_callbacks'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/middleware/callbacks.rb:27:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/middleware/remote_ip.rb:31:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/middleware/debug_exceptions.rb:16:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/middleware/show_exceptions.rb:56:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/railties-3.2.11/lib/rails/rack/logger.rb:32:in `call_app'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/railties-3.2.11/lib/rails/rack/logger.rb:16:in `block in call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activesupport-3.2.11/lib/active_support/tagged_logging.rb:22:in `tagged'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/railties-3.2.11/lib/rails/rack/logger.rb:16:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/middleware/request_id.rb:22:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/rack-1.4.5/lib/rack/methodoverride.rb:21:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/rack-1.4.5/lib/rack/runtime.rb:17:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/activesupport-3.2.11/lib/active_support/cache/strategy/local_cache.rb:72:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/rack-1.4.5/lib/rack/lock.rb:15:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/middleware/static.rb:62:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/rack-cache-1.2/lib/rack/cache/context.rb:136:in `forward'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/rack-cache-1.2/lib/rack/cache/context.rb:245:in `fetch'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/rack-cache-1.2/lib/rack/cache/context.rb:185:in `lookup'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/rack-cache-1.2/lib/rack/cache/context.rb:66:in `call!'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/rack-cache-1.2/lib/rack/cache/context.rb:51:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/railties-3.2.11/lib/rails/engine.rb:479:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/railties-3.2.11/lib/rails/application.rb:223:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/rack-1.4.5/lib/rack/content_length.rb:14:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/railties-3.2.11/lib/rails/rack/log_tailer.rb:17:in `call'
[Fri Feb 22 11:56:00 2013] info   vendor/bundle/ruby/1.9.1/gems/rack-1.4.5/lib/rack/handler/webrick.rb:59:in `service'
[Fri Feb 22 11:56:00 2013] info   /usr/lib/ruby/1.9.1/webrick/httpserver.rb:138:in `service'
[Fri Feb 22 11:56:00 2013] info   /usr/lib/ruby/1.9.1/webrick/httpserver.rb:94:in `run'
[Fri Feb 22 11:56:00 2013] info   /usr/lib/ruby/1.9.1/webrick/server.rb:191:in `block in start_thread'
@ka8725

This comment has been minimized.

Owner

ka8725 commented Feb 22, 2013

It seems to me that you have deleted the attachment entity through database but it has not been deleted from s3.

heroku console
> Attachment.all.map(&:id).include?(4)

Does it return false or true?

@morytox

This comment has been minimized.

morytox commented Feb 22, 2013

irb(main):001:0> Attachment.all.map(&:id).include?(4)
Attachment Load (0.9ms) SELECT attachments.* FROM attachments
=> true

@ka8725

This comment has been minimized.

Owner

ka8725 commented Feb 22, 2013

cat lib/redmine_s3/attachment_patch.rb

@morytox

This comment has been minimized.

morytox commented Feb 22, 2013

u27500@depdekyyyny-27500:~/www$ cat lib/redmine_s3/attachment_patch.rb
cat: lib/redmine_s3/attachment_patch.rb: No such file or directory
u27500@depdekyyyny-27500:~/www$ cat plugins/redmine_s3/lib/redmine_s3/attachment_patch.rb
module RedmineS3
  module AttachmentPatch
    def self.included(base) # :nodoc:
      base.extend(ClassMethods)
      base.send(:include, InstanceMethods)

      # Same as typing in the class
      base.class_eval do
        unloadable # Send unloadable so it will not be unloaded in development
        attr_accessor :s3_access_key_id, :s3_secret_acces_key, :s3_bucket, :s3_bucket
        after_validation :put_to_s3
        before_destroy   :delete_from_s3
      end
    end

    module ClassMethods
    end

    module InstanceMethods
      def put_to_s3
        if @temp_file && (@temp_file.size > 0)
          logger.debug("Uploading to #{disk_filename}")
          self.digest = RedmineS3::Connection.put(self, @temp_file)
        end
        @temp_file = nil # so that the model's original after_save block skips writing to the fs
      end

      def delete_from_s3
        logger.debug("Deleting #{disk_filename}")
        RedmineS3::Connection.delete(disk_filename)
      end

      # Prevent saving to file system and generating the new disk_filename
      def files_to_final_location; true end
    end
  end
end
@ka8725

This comment has been minimized.

Owner

ka8725 commented Feb 22, 2013

Ok, now let's see actual version of this file. Do you know what to do or still have questions?

@nberger

This comment has been minimized.

nberger commented Feb 22, 2013

Hey,

Just for the record, this issue is different from that which was fixed in the original issue. Original issue was a problem with upload, this is a problem with download. I suggest to move this problem to another issue.

Apart from that, it seems the attachment was not found, that's why @attachment is nil in https://github.com/ka8725/redmine_s3/blob/master/lib/redmine_s3/attachments_controller_patch.rb#L20

@ka8725

This comment has been minimized.

Owner

ka8725 commented Feb 22, 2013

@nberger, pay attention that @morytox uses old version of plugin. Doesn't it?

@morytox

This comment has been minimized.

morytox commented Feb 22, 2013

i'am using redmine-2.2.3

@nberger

This comment has been minimized.

nberger commented Feb 22, 2013

@nberger, pay attention that @morytox uses old version of plugin. Doesn't it?

Yes, that's right. @morytox could you please try with the current version of redimne_s3?

@morytox

This comment has been minimized.

morytox commented Feb 22, 2013

This one with masterbranch ?
https://github.com/ka8725/redmine_s3

@ka8725

This comment has been minimized.

Owner

ka8725 commented Feb 22, 2013

Yes

@morytox

This comment has been minimized.

morytox commented Feb 22, 2013

still the error ...

[Fri Feb 22 13:52:37 2013] info Started GET "/attachments/5?t=1361541152&version=true" for 178.19.208.122 at 2013-02-22 13:52:37 +0000
[Fri Feb 22 13:52:37 2013] info Processing by AttachmentsController#show as HTML
[Fri Feb 22 13:52:37 2013] info Parameters: {"t"=>"1361541152", "version"=>"true", "id"=>"5"}
[Fri Feb 22 13:52:37 2013] info Current user: felix.knoepke (id=21)
[Fri Feb 22 13:52:37 2013] info Completed 500 Internal Server Error in 7ms
[Fri Feb 22 13:52:37 2013] info
[Fri Feb 22 13:52:37 2013] info NoMethodError (undefined method container' for nil:NilClass): [Fri Feb 22 13:52:37 2013] info plugins/redmine_s3/lib/redmine_s3/attachments_controller_patch.rb:20:inredirect_to_s3'

And Following Result:

irb(main):001:0> Attachment.all.map(&:id).include?(4)
Attachment Load (1.8ms) SELECT attachments.* FROM attachments
=> false

@morytox

This comment has been minimized.

morytox commented Feb 22, 2013

sry, id 5 which i tried to load is there,

Attachment.all.map(&:id).include?(5) = true

@ka8725

This comment has been minimized.

Owner

ka8725 commented Feb 22, 2013

What about web server restarting?

@morytox

This comment has been minimized.

morytox commented Feb 22, 2013

i upload the updated application repo onto the paas, so the server is started again every time i change the code

@morytox

This comment has been minimized.

morytox commented Feb 22, 2013

you have no ideas don't you ?

@nberger

This comment has been minimized.

nberger commented Feb 23, 2013

I don't see how the attachment can be found in https://github.com/redmine/redmine/blob/2.2.3/app/controllers/attachments_controller.rb#L111, but be nil in https://github.com/ka8725/redmine_s3/blob/master/lib/redmine_s3/attachments_controller_patch.rb#L20

Maybe find_project is being skipped? Maybe another plugin is causing this issue, are you using any other plugin?`

@morytox

This comment has been minimized.

morytox commented Feb 23, 2013

Its easy redmine what i use. I think its just a kind of plugin turning remine to easyredmine.

@nberger

This comment has been minimized.

nberger commented Feb 23, 2013

Please open a separate ticket if you would like to have support for easyredmine. But as easyredmine seems to be closed source, it would probably be better to ask easyredmine to add support for S3 attachments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment