Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Refactor serializer class similar to response class #2

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

mattp- commented Apr 2, 2012

Allows for extension or overriding of serializer object.

Contributor

wreis commented May 22, 2012

But then, in order to be really extensible, the "_serializer_class" bit needs to be a public attr with proper default or the "_new_serializer" method needs to be public. I wouldn't extend the Role::REST::Client behavior relying on private methods.

Contributor

wreis commented May 22, 2012

@kaare Please, lemme know if you agree with that, then I will do a pull request.

Owner

kaare commented May 22, 2012

@kaare Please, lemme know if you agree with that, then I will do a pull
request.

Go ahead.

wreis pushed a commit to wreis/Role-REST-Client that referenced this pull request May 22, 2012

kaare added a commit that referenced this pull request May 23, 2012

Merge pull request #3 from wreis/extend_serializer
Issue #2. Make new_serializer and serializer_class public method...
Owner

kaare commented Nov 11, 2012

Merged into 0.07

@kaare kaare closed this Nov 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment