New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As part of the Pull Request Challenge, Minilla & Carton #1

Merged
merged 7 commits into from Feb 10, 2015

Conversation

Projects
None yet
2 participants
@jeturcotte

jeturcotte commented Jan 27, 2015

So, I took your suggestion to heart, given that this originates from an orchestrated challenge, as this task involved trying a number of new things... pull requests, for example... but also minilla and carton I've never had opportunity or cause to try. So far as I can tell, this works. Apologies for any oversights.

@kablamo

This comment has been minimized.

Show comment
Hide comment
@kablamo

kablamo Jan 27, 2015

Owner

Cool. Thanks for this. I will try to get to this this week.

Owner

kablamo commented Jan 27, 2015

Cool. Thanks for this. I will try to get to this this week.

@jeturcotte

This comment has been minimized.

Show comment
Hide comment
@jeturcotte

jeturcotte Jan 27, 2015

No problem; it occurred to me after the fact that the cpanfile.snapshot
might have been better served in the .gitignore, but maybe not. Still feel
like I overlooked something, but if you find out what it is, I'm all ears.

On Tue, Jan 27, 2015 at 1:06 PM, Eric Johnson notifications@github.com
wrote:

Cool. Thanks for this. I will try to get to this this week.


Reply to this email directly or view it on GitHub
#1 (comment)
.

~jet

jeturcotte commented Jan 27, 2015

No problem; it occurred to me after the fact that the cpanfile.snapshot
might have been better served in the .gitignore, but maybe not. Still feel
like I overlooked something, but if you find out what it is, I'm all ears.

On Tue, Jan 27, 2015 at 1:06 PM, Eric Johnson notifications@github.com
wrote:

Cool. Thanks for this. I will try to get to this this week.


Reply to this email directly or view it on GitHub
#1 (comment)
.

~jet

@kablamo

This comment has been minimized.

Show comment
Hide comment
@kablamo

kablamo Jan 31, 2015

Owner

@jeturcotte You were right to add cpanfile.snapshot to the repo. Read carton --help if you are interested in the details.

However minil test and minil dist should work but are failing atm. I think the version numbers are not setup right?

Owner

kablamo commented Jan 31, 2015

@jeturcotte You were right to add cpanfile.snapshot to the repo. Read carton --help if you are interested in the details.

However minil test and minil dist should work but are failing atm. I think the version numbers are not setup right?

@jeturcotte

This comment has been minimized.

Show comment
Hide comment
@jeturcotte

jeturcotte Jan 31, 2015

Right; I will poke at them this weekend

On Fri, Jan 30, 2015 at 8:23 PM, Eric Johnson notifications@github.com
wrote:

@jeturcotte https://github.com/jeturcotte You were right to add
cpanfile.snapshot to the repo. Read carton --help if you are interested
in the details.

However minil test and minil dist should work but are failing atm. I
think the version numbers are not setup right?


Reply to this email directly or view it on GitHub
#1 (comment)
.

~jet

jeturcotte commented Jan 31, 2015

Right; I will poke at them this weekend

On Fri, Jan 30, 2015 at 8:23 PM, Eric Johnson notifications@github.com
wrote:

@jeturcotte https://github.com/jeturcotte You were right to add
cpanfile.snapshot to the repo. Read carton --help if you are interested
in the details.

However minil test and minil dist should work but are failing atm. I
think the version numbers are not setup right?


Reply to this email directly or view it on GitHub
#1 (comment)
.

~jet

@jeturcotte

This comment has been minimized.

Show comment
Hide comment
@jeturcotte

jeturcotte Feb 9, 2015

It's in better shape now; had to diminish my version of MooseX::Test::Role down to 0.02 from 0.06, and also fiddle with a little pod as it kept injecting complaints about those... but test and dist both appear happy.

jeturcotte commented Feb 9, 2015

It's in better shape now; had to diminish my version of MooseX::Test::Role down to 0.02 from 0.06, and also fiddle with a little pod as it kept injecting complaints about those... but test and dist both appear happy.

@kablamo

This comment has been minimized.

Show comment
Hide comment
@kablamo

kablamo Feb 10, 2015

Owner

Nice work! I really like Carton and Minilla. I think minilla automatically added you to the META.json as a contributer too which is cool. So your name should show up on the cpan page.

I might tweak a couple little things after, but this is good enough to merge. I'm not sure why my synopsis is in the middle of the pod for example. But thats not your fault. That was me who wrote it that way. And I will probably add travis and coveralls.

I really appreciate this pr, thanks! 👍

Owner

kablamo commented Feb 10, 2015

Nice work! I really like Carton and Minilla. I think minilla automatically added you to the META.json as a contributer too which is cool. So your name should show up on the cpan page.

I might tweak a couple little things after, but this is good enough to merge. I'm not sure why my synopsis is in the middle of the pod for example. But thats not your fault. That was me who wrote it that way. And I will probably add travis and coveralls.

I really appreciate this pr, thanks! 👍

kablamo added a commit that referenced this pull request Feb 10, 2015

Merge pull request #1 from jeturcotte/master
As part of the Pull Request Challenge, Minilla & Carton

@kablamo kablamo merged commit b31e11e into kablamo:master Feb 10, 2015

@kablamo

This comment has been minimized.

Show comment
Hide comment
@kablamo

kablamo Feb 10, 2015

Owner

Released. You'll see your name on the right if you click the 'show them' link under contributers.

https://metacpan.org/pod/release/KABLAMO/MooseX-CachingProxy-0.002/lib/MooseX/CachingProxy.pm

Owner

kablamo commented Feb 10, 2015

Released. You'll see your name on the right if you click the 'show them' link under contributers.

https://metacpan.org/pod/release/KABLAMO/MooseX-CachingProxy-0.002/lib/MooseX/CachingProxy.pm

@jeturcotte

This comment has been minimized.

Show comment
Hide comment
@jeturcotte

jeturcotte Feb 10, 2015

No problem; and yes, it's only natural that there'll be tweaks. Travis is
something else I need to become familiar with at some point. Anyhow,
cool... thanks again. February challenge came in (another moose thing!)
and that individual is unresponsive, which complicates things a little
bit. Have a good one!

On Mon, Feb 9, 2015 at 7:42 PM, Eric Johnson notifications@github.com
wrote:

Released. You'll see your name on the right if you click the 'show them'
link under contributers.

https://metacpan.org/pod/release/KABLAMO/MooseX-CachingProxy-0.002/lib/MooseX/CachingProxy.pm


Reply to this email directly or view it on GitHub
#1 (comment)
.

~jet

jeturcotte commented Feb 10, 2015

No problem; and yes, it's only natural that there'll be tweaks. Travis is
something else I need to become familiar with at some point. Anyhow,
cool... thanks again. February challenge came in (another moose thing!)
and that individual is unresponsive, which complicates things a little
bit. Have a good one!

On Mon, Feb 9, 2015 at 7:42 PM, Eric Johnson notifications@github.com
wrote:

Released. You'll see your name on the right if you click the 'show them'
link under contributers.

https://metacpan.org/pod/release/KABLAMO/MooseX-CachingProxy-0.002/lib/MooseX/CachingProxy.pm


Reply to this email directly or view it on GitHub
#1 (comment)
.

~jet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment