Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI fails to take external storage option #199

Closed
amarts opened this issue Mar 2, 2020 · 1 comment
Closed

CLI fails to take external storage option #199

amarts opened this issue Mar 2, 2020 · 1 comment
Labels
bug
Milestone

Comments

@amarts
Copy link
Member

@amarts amarts commented Mar 2, 2020

$ kubectl-kadalu storage-add kadalu-test --external http://redacted-mgmt-a02d.my-domain.net:/kadalu-test

=> Invalid external storage details. Please specify details in the format :/

Credits: Twitter User - Stonecut2010

@amarts amarts added the bug label Mar 2, 2020
@amarts

This comment has been minimized.

Copy link
Member Author

@amarts amarts commented Mar 2, 2020

@aravindavk took a look and found that the issue is, external option is treated like an array (like --device etc), but it is indeed a string. Hence the failure.

Two things needed here:

  1. Fix the issue (ie, fix CLI tool)
  2. Add Test cases for all these cases (#195)
@amarts amarts added this to the v0.6 milestone Mar 2, 2020
aravindavk added a commit that referenced this issue Mar 2, 2020
Fixes: #199
Signed-off-by: Aravinda Vishwanathapura <aravinda@kadalu.io>
@amarts amarts closed this in #200 Mar 2, 2020
amarts pushed a commit that referenced this issue Mar 2, 2020
…#200)

Fixes: #199
Signed-off-by: Aravinda Vishwanathapura <aravinda@kadalu.io>
amarts added a commit to amarts/kadalu that referenced this issue Mar 2, 2020
amarts added a commit to amarts/kadalu that referenced this issue Mar 2, 2020
amarts added a commit to amarts/kadalu that referenced this issue Mar 2, 2020
amarts added a commit to amarts/kadalu that referenced this issue Mar 2, 2020
amarts added a commit to amarts/kadalu that referenced this issue Mar 2, 2020
amarts added a commit to amarts/kadalu that referenced this issue Mar 2, 2020
amarts added a commit to amarts/kadalu that referenced this issue Mar 2, 2020
amarts added a commit to amarts/kadalu that referenced this issue Mar 2, 2020
amarts added a commit to amarts/kadalu that referenced this issue Mar 2, 2020
Updates: kadalu#199
Fixes: kadalu#204, kadalu#203

* reduce readinessprobe timeout
* ignore the external PV test (non-kadalu)
* operator: never pass a nil value to yaml file
* fix hostname dns format
amarts added a commit to amarts/kadalu that referenced this issue Mar 2, 2020
Updates: kadalu#199
Fixes: kadalu#204, kadalu#203

* reduce readinessprobe timeout
* ignore the external PV test (non-kadalu)
* operator: never pass a nil value to yaml file
* fix hostname dns format
amarts added a commit to amarts/kadalu that referenced this issue Mar 2, 2020
Updates: kadalu#199
Fixes: kadalu#204, kadalu#203

* reduce readinessprobe timeout
* ignore the external PV test (non-kadalu)
* operator: never pass a nil value to yaml file
* fix hostname dns format
amarts added a commit to amarts/kadalu that referenced this issue Mar 2, 2020
Updates: kadalu#199
Fixes: kadalu#204, kadalu#203

* reduce readinessprobe timeout
* ignore the external PV test (non-kadalu)
* operator: never pass a nil value to yaml file
* fix hostname dns format
amarts added a commit that referenced this issue Mar 3, 2020
* reduce readinessprobe timeout
* ignore the external PV test (non-kadalu)
* operator: never pass a nil value to yaml file
* fix hostname dns format

Updates: #199
Fixes: #204, #203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.