Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth some UX edges in the SPV API #452

Merged
merged 11 commits into from Sep 20, 2019
Merged

Smooth some UX edges in the SPV API #452

merged 11 commits into from Sep 20, 2019

Conversation

@emilypi
Copy link
Contributor

emilypi commented Sep 18, 2019

Currently, we take a chainweb chain id as a parameter to the SPV api, but this creates some unsatisfying UX, where the user submits a Pact chain id as a parameter to a cross-chain transfer, but then has to remember to switch from pact to chainweb chain id's (raw word32's) for the SPV api in the pact service. This is bad UX. This PR makes it Pact Chain Ids the whole way so that the user only ever specifies pact types as parameters to the pact service.

emilypi added 6 commits Sep 18, 2019
…web-node into emily/spv-chainid-format
emilypi added 5 commits Sep 19, 2019
@emilypi emilypi merged commit 85cfe00 into master Sep 20, 2019
1 check passed
1 check passed
ci/gitlab/gitlab.com Pipeline passed on GitLab
Details
@emilypi emilypi deleted the emily/spv-chainid-format branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.