Pact step signatures #565
Merged
Pact step signatures #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `CheckableType`s which are always `CheckDefun`.
This allows us to successfully check our first steps.
This is perhaps not the best message -- "entering step with arguments ...", which could be confusing, since the arguments come from the `defpact`, not the step. Perhaps we should add a new scope type.
joelburget
commented
Jul 2, 2019
bts
reviewed
Jul 3, 2019
`verifyFunctionInvariants` and `verifyFunctionProperty`.
This previously caused checking of `defpact`s to fail due to the wrong `CheckableType`.
This fixes the remaining two tests that were failing.
This was not possible before because it relies on b6659de.
bts
reviewed
Jul 9, 2019
| , invariantChecks :: HM.HashMap Text (TableMap [CheckResult]) | ||
| , moduleWarnings :: VerificationWarnings | ||
| } deriving (Eq, Show) | ||
|
|
||
| data CheckEnv = CheckEnv |
bts
reviewed
Jul 9, 2019
| -- use this structure for invariant checks, which don't check any props. We | ||
| -- also use it for checking pact steps which are a different check type and | ||
| -- borrow the name of their enclosing pact. | ||
| data FunData = FunData |
bts
reviewed
Jul 9, 2019
| handlePositiveTestResult :: Maybe TestFailure -> IO () | ||
| handlePositiveTestResult = \case | ||
| handlePositiveTestResult :: HasCallStack => Maybe TestFailure -> IO () | ||
| handlePositiveTestResult = withFrozenCallStack $ \case |
There was a problem hiding this comment.
This is cool! I had no idea about this function.
* origin/master: Change 'executed' output to 'Maybe Bool' to indicate private exec (#560) Write a few older tests in terms of new testing system. Roll back (not needed) analysis write validation. Rewrite expected failure properties. Small alignment tweak. Analysis write validation.
|
I added another case to |
bts
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.