Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pact step signatures #565

Merged
merged 33 commits into from Jul 9, 2019
Merged

Pact step signatures #565

merged 33 commits into from Jul 9, 2019

Conversation

joelburget
Copy link
Contributor

@joelburget joelburget commented Jul 2, 2019

No description provided.

@joelburget joelburget requested a review from bts Jul 2, 2019
src/Pact/Analyze/Check.hs Show resolved Hide resolved
src/Pact/Analyze/Check.hs Outdated Show resolved Hide resolved
src/Pact/Analyze/Translate.hs Outdated Show resolved Hide resolved
src/Pact/Types/Typecheck.hs Show resolved Hide resolved
src/Pact/Analyze/Check.hs Outdated Show resolved Hide resolved
src/Pact/Analyze/Check.hs Show resolved Hide resolved
src/Pact/Types/Typecheck.hs Outdated Show resolved Hide resolved
joelburget added 5 commits Jul 3, 2019
`verifyFunctionInvariants` and `verifyFunctionProperty`.
This previously caused checking of `defpact`s to fail due to the wrong
`CheckableType`.
joelburget added 4 commits Jul 8, 2019
This fixes the remaining two tests that were failing.
This was not possible before because it relies on b6659de.
@joelburget joelburget marked this pull request as ready for review Jul 8, 2019
, invariantChecks :: HM.HashMap Text (TableMap [CheckResult])
, moduleWarnings :: VerificationWarnings
} deriving (Eq, Show)

data CheckEnv = CheckEnv
Copy link
Contributor

@bts bts Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

-- use this structure for invariant checks, which don't check any props. We
-- also use it for checking pact steps which are a different check type and
-- borrow the name of their enclosing pact.
data FunData = FunData
Copy link
Contributor

@bts bts Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

handlePositiveTestResult :: Maybe TestFailure -> IO ()
handlePositiveTestResult = \case
handlePositiveTestResult :: HasCallStack => Maybe TestFailure -> IO ()
handlePositiveTestResult = withFrozenCallStack $ \case
Copy link
Contributor

@bts bts Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool! I had no idea about this function.

bts added 2 commits Jul 9, 2019
* origin/master:
  Change 'executed' output to 'Maybe Bool' to indicate private exec (#560)
  Write a few older tests in terms of new testing system.
  Roll back (not needed) analysis write validation.
  Rewrite expected failure properties.
  Small alignment tweak.
  Analysis write validation.
@bts
Copy link
Contributor

@bts bts commented Jul 9, 2019

I added another case to expectFailsTypechecking because apparently on master now, the typechecking error seems to be reported at the module level.

bts
bts approved these changes Jul 9, 2019
@bts bts merged commit f3ed10b into master Jul 9, 2019
2 of 3 checks passed
@bts bts deleted the pact-step-signatures branch Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants