Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pact step signatures #565

Merged
merged 33 commits into from Jul 9, 2019
Merged

Pact step signatures #565

merged 33 commits into from Jul 9, 2019

Conversation

@joelburget
Copy link
Contributor

joelburget commented Jul 2, 2019

No description provided.

joelburget added 18 commits Jun 21, 2019
Remove `CheckableType`s which are always `CheckDefun`.
This allows us to successfully check our first steps.
This is perhaps not the best message -- "entering step with arguments
...", which could be confusing, since the arguments come from the
`defpact`, not the step. Perhaps we should add a new scope type.
@joelburget joelburget requested a review from bts Jul 2, 2019
src/Pact/Analyze/Check.hs Show resolved Hide resolved
src/Pact/Analyze/Check.hs Outdated Show resolved Hide resolved
src/Pact/Analyze/Translate.hs Outdated Show resolved Hide resolved
src/Pact/Types/Typecheck.hs Show resolved Hide resolved
src/Pact/Analyze/Check.hs Outdated Show resolved Hide resolved
src/Pact/Analyze/Check.hs Show resolved Hide resolved
src/Pact/Types/Typecheck.hs Outdated Show resolved Hide resolved
joelburget added 5 commits Jul 3, 2019
`verifyFunctionInvariants` and `verifyFunctionProperty`.
This previously caused checking of `defpact`s to fail due to the wrong
`CheckableType`.
joelburget added 4 commits Jul 8, 2019
This fixes the remaining two tests that were failing.
This was not possible before because it relies on b6659de.
@joelburget joelburget marked this pull request as ready for review Jul 8, 2019
, invariantChecks :: HM.HashMap Text (TableMap [CheckResult])
, moduleWarnings :: VerificationWarnings
} deriving (Eq, Show)

data CheckEnv = CheckEnv

This comment has been minimized.

Copy link
@bts

bts Jul 9, 2019

Contributor

👍

-- use this structure for invariant checks, which don't check any props. We
-- also use it for checking pact steps which are a different check type and
-- borrow the name of their enclosing pact.
data FunData = FunData

This comment has been minimized.

Copy link
@bts

bts Jul 9, 2019

Contributor

👍

handlePositiveTestResult :: Maybe TestFailure -> IO ()
handlePositiveTestResult = \case
handlePositiveTestResult :: HasCallStack => Maybe TestFailure -> IO ()
handlePositiveTestResult = withFrozenCallStack $ \case

This comment has been minimized.

Copy link
@bts

bts Jul 9, 2019

Contributor

This is cool! I had no idea about this function.

bts added 2 commits Jul 9, 2019
* origin/master:
  Change 'executed' output to 'Maybe Bool' to indicate private exec (#560)
  Write a few older tests in terms of new testing system.
  Roll back (not needed) analysis write validation.
  Rewrite expected failure properties.
  Small alignment tweak.
  Analysis write validation.
@bts

This comment has been minimized.

Copy link
Contributor

bts commented Jul 9, 2019

I added another case to expectFailsTypechecking because apparently on master now, the typechecking error seems to be reported at the module level.

@bts
bts approved these changes Jul 9, 2019
@bts bts merged commit f3ed10b into master Jul 9, 2019
2 of 3 checks passed
2 of 3 checks passed
ci/gitlab/gitlab.com Pipeline canceled on GitLab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bts bts deleted the pact-step-signatures branch Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.