Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Imports + Myriad Bug Fixes #585

Merged
merged 35 commits into from Sep 12, 2019
Merged

Add Imports + Myriad Bug Fixes #585

merged 35 commits into from Sep 12, 2019

Conversation

@emilypi
Copy link
Collaborator

emilypi commented Jul 15, 2019

This PR will address #567, #568, #571, #572, #580, #586

TODO:

  • disable use imports for interfaces
  • disallow name overloads in module bodies
  • typecheck on interfaces trivially succeeds
  • disallow native name overlap with local module definitions
  • add import list feature to use

EDIT: We've decided that importing interfaces is perfectly fine behavior

docs/en/pact-reference.md Outdated Show resolved Hide resolved
src/Pact/Eval.hs Outdated Show resolved Hide resolved
emilypi added 2 commits Jul 15, 2019
@emilypi emilypi marked this pull request as ready for review Jul 15, 2019
emilypi added 3 commits Jul 16, 2019
@emilypi emilypi requested a review from slpopejoy Jul 17, 2019
@emilypi emilypi changed the title Myriad Bug Fixes Add Imports + Myriad Bug Fixes Jul 20, 2019
cabal.project Outdated Show resolved Hide resolved
src/Pact/Eval.hs Show resolved Hide resolved
src/Pact/Eval.hs Show resolved Hide resolved
emilypi added 6 commits Jul 21, 2019
Copy link
Contributor

slpopejoy left a comment

great

src/Pact/Eval.hs Outdated Show resolved Hide resolved
src/Pact/Types/ExpParser.hs Outdated Show resolved Hide resolved
src/Pact/Eval.hs Outdated Show resolved Hide resolved
tests/pact/bad/bad-import-emptylist.pact Show resolved Hide resolved
tests/pact/tc.repl Outdated Show resolved Hide resolved
tests/pact/tc.repl Outdated Show resolved Hide resolved
emilypi and others added 6 commits Sep 12, 2019
Co-Authored-By: Stuart Popejoy <slpopejoy@users.noreply.github.com>
Co-Authored-By: Stuart Popejoy <slpopejoy@users.noreply.github.com>
@emilypi emilypi merged commit 2730879 into master Sep 12, 2019
3 checks passed
3 checks passed
ci/gitlab/gitlab.com Pipeline passed on GitLab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@emilypi emilypi deleted the emily/bugfix-571 branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.