Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Imports + Myriad Bug Fixes #585

Merged
merged 35 commits into from Sep 12, 2019
Merged

Add Imports + Myriad Bug Fixes #585

merged 35 commits into from Sep 12, 2019

Conversation

emilypi
Copy link
Member

@emilypi emilypi commented Jul 15, 2019

This PR will address #567, #568, #571, #572, #580, #586

TODO:

  • disable use imports for interfaces
  • disallow name overloads in module bodies
  • typecheck on interfaces trivially succeeds
  • disallow native name overlap with local module definitions
  • add import list feature to use

EDIT: We've decided that importing interfaces is perfectly fine behavior

docs/en/pact-reference.md Outdated Show resolved Hide resolved
src/Pact/Eval.hs Outdated Show resolved Hide resolved
@emilypi emilypi marked this pull request as ready for review Jul 15, 2019
@emilypi emilypi requested a review from sirlensalot Jul 17, 2019
@emilypi emilypi changed the title Myriad Bug Fixes Add Imports + Myriad Bug Fixes Jul 20, 2019
cabal.project Outdated Show resolved Hide resolved
src/Pact/Eval.hs Show resolved Hide resolved
src/Pact/Eval.hs Show resolved Hide resolved
Copy link
Collaborator

@sirlensalot sirlensalot left a comment

great

src/Pact/Eval.hs Outdated Show resolved Hide resolved
src/Pact/Types/ExpParser.hs Outdated Show resolved Hide resolved
src/Pact/Eval.hs Outdated Show resolved Hide resolved
tests/pact/bad/bad-import-emptylist.pact Show resolved Hide resolved
tests/pact/tc.repl Outdated Show resolved Hide resolved
tests/pact/tc.repl Outdated Show resolved Hide resolved
emilypi and others added 6 commits Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants