Skip to content

Conversation

@germanosin
Copy link
Member

…EW permission

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@germanosin germanosin requested a review from a team as a code owner November 21, 2025 12:26
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Nov 21, 2025
@germanosin germanosin added this to the 1.5 milestone Nov 21, 2025
@germanosin germanosin linked an issue Nov 21, 2025 that may be closed by this pull request
4 tasks
@germanosin germanosin requested a review from Copilot November 21, 2025 12:27
Copilot finished reviewing on behalf of germanosin November 21, 2025 12:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #1511 by changing the permission requirement for the Connectors tab from ANALYSIS_VIEW to VIEW, making it accessible to users with basic view permissions rather than requiring analytics-specific permissions.

Key changes:

  • Updated the Connectors tab permission from Action.ANALYSIS_VIEW to Action.VIEW in the Topics component
Comments suppressed due to low confidence (1)

frontend/src/components/Topics/Topic/Topic.tsx:248

  • The Connectors tab lacks test coverage. Other tabs (Overview, Messages, Consumers, Settings, Statistics) have tests in Topic.spec.tsx, but there's no test case for the Connectors tab even though the component is imported and used. Consider adding a test similar to the other tab tests:
it('renders Connectors tab', () => {
  itExpectsCorrectPageRendered(
    clusterTopicConnectorsPath(),
    'Connectors',
    'ConnectorsMock'
  );
});

And add the corresponding mock at the top of the test file:

jest.mock('components/Topics/Topic/Connectors/Connectors', () => () => (
  <>ConnectorsMock</>
));
        {isConnectorsAvailable && (
          <ActionNavLink
            to={clusterTopicConnectorsRelativePath}
            className={({ isActive }) => (isActive ? 'is-active' : '')}
            permission={{
              resource: ResourceType.TOPIC,
              action: Action.VIEW,
              value: topicName,
            }}
          >
            Connectors
          </ActionNavLink>
        )}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-project-automation github-project-automation bot moved this from Todo to PR Approved in Release 1.5 Nov 21, 2025
@Haarolean Haarolean added scope/backend Related to backend changes type/bug Something isn't working area/topics labels Nov 21, 2025
@Haarolean Haarolean changed the title FE: Fixes issue #1511 Allow to view connector tab without ANALYSIS_VI… FE: Topics: Fix connectors tab permissions Nov 21, 2025
@germanosin germanosin enabled auto-merge (squash) November 24, 2025 16:58
@germanosin germanosin merged commit 2aba22b into main Nov 24, 2025
12 of 13 checks passed
@germanosin germanosin deleted the issue/1511-fe branch November 24, 2025 17:00
@github-project-automation github-project-automation bot moved this from PR Approved to Done in Release 1.5 Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/topics scope/backend Related to backend changes status/triage/completed Automatic triage completed type/bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Bug: "Connectors" tab requires analysis_run/analysis_view permissions

3 participants