Skip to content

Set sane default values for SSL settings #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Set sane default values for SSL settings #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/kafka_ex/config.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ defmodule KafkaEx.Config do
require Logger

@doc false
def use_ssl, do: Application.get_env(:kafka_ex, :use_ssl)
def use_ssl, do: Application.get_env(:kafka_ex, :use_ssl, false)

# use this function to get the ssl options - it verifies the options and
# either emits warnings or raises errors as appropriate on misconfiguration
@doc false
def ssl_options do
ssl_options(use_ssl(), Application.get_env(:kafka_ex, :ssl_options))
ssl_options(use_ssl(), Application.get_env(:kafka_ex, :ssl_options, []))
end

@doc false
Expand All @@ -37,7 +37,6 @@ defmodule KafkaEx.Config do

# ssl_options should be an empty list by default if use_ssl is false
defp ssl_options(false, []), do: []
defp ssl_options(false, nil), do: []
# emit a warning if use_ssl is false but options are present
# (this is not a fatal error and can occur if one disables ssl in the
# default option set)
Expand Down