From 8472c5b4c90a7a7eb69b534800e28f7a160d3216 Mon Sep 17 00:00:00 2001 From: Enrique Fernandez Date: Mon, 2 Apr 2018 15:05:28 +0200 Subject: [PATCH 1/2] Enable default worker by default --- lib/kafka_ex.ex | 2 +- lib/kafka_ex/config.ex | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/kafka_ex.ex b/lib/kafka_ex.ex index 97c7111d..401c66c7 100644 --- a/lib/kafka_ex.ex +++ b/lib/kafka_ex.ex @@ -533,7 +533,7 @@ defmodule KafkaEx do max_seconds = Application.get_env(:kafka_ex, :max_seconds, 60) {:ok, pid} = KafkaEx.Supervisor.start_link(Config.server_impl, max_restarts, max_seconds) - if Application.get_env(:kafka_ex, :disable_default_worker) == true do + if Config.disable_default_worker do {:ok, pid} else case KafkaEx.create_worker(Config.default_worker, []) do diff --git a/lib/kafka_ex/config.ex b/lib/kafka_ex/config.ex index bf1fb671..89d41c81 100644 --- a/lib/kafka_ex/config.ex +++ b/lib/kafka_ex/config.ex @@ -9,6 +9,11 @@ defmodule KafkaEx.Config do require Logger + @doc false + def disable_default_worker do + Application.get_env(:kafka_ex, :disable_default_worker, false) + end + @doc false def use_ssl, do: Application.get_env(:kafka_ex, :use_ssl, false) From 3aaa0bb001ef769d7ade722d8cbc83e57a571d87 Mon Sep 17 00:00:00 2001 From: Enrique Fernandez Date: Mon, 2 Apr 2018 15:11:11 +0200 Subject: [PATCH 2/2] Set "kafka_ex" as the default consumer group --- lib/kafka_ex.ex | 2 +- lib/kafka_ex/config.ex | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/kafka_ex.ex b/lib/kafka_ex.ex index 401c66c7..cd6f3037 100644 --- a/lib/kafka_ex.ex +++ b/lib/kafka_ex.ex @@ -485,7 +485,7 @@ defmodule KafkaEx do def build_worker_options(worker_init) do defaults = [ uris: Application.get_env(:kafka_ex, :brokers), - consumer_group: Application.get_env(:kafka_ex, :consumer_group), + consumer_group: Config.consumer_group(), use_ssl: Config.use_ssl(), ssl_options: Config.ssl_options(), ] diff --git a/lib/kafka_ex/config.ex b/lib/kafka_ex/config.ex index 89d41c81..5d4ca63b 100644 --- a/lib/kafka_ex/config.ex +++ b/lib/kafka_ex/config.ex @@ -14,6 +14,11 @@ defmodule KafkaEx.Config do Application.get_env(:kafka_ex, :disable_default_worker, false) end + @doc false + def consumer_group do + Application.get_env(:kafka_ex, :consumer_group, "kafka_ex") + end + @doc false def use_ssl, do: Application.get_env(:kafka_ex, :use_ssl, false)