New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify requirements for application configuration with elixir >= 1.4 #317

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
2 participants
@skateinmars
Copy link
Contributor

skateinmars commented Oct 14, 2018

Starting with elixir 1.4, there is no need to explicitly add dependencies to the applications list. I updated the readme to reflect this change.

I kept the instructions for users of elixir < 1.4, but I'm not sure how many people there are still using this version, so it may be be unneeded?

@skateinmars skateinmars changed the title Clarify requirements for application configuration with elixir > 1.4 Clarify requirements for application configuration with elixir >= 1.4 Oct 14, 2018

@ebert

This comment has been minimized.

Copy link

ebert bot commented Oct 14, 2018

Hello, @skateinmars! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@joshuawscott
Copy link
Collaborator

joshuawscott left a comment

Thanks!

@joshuawscott joshuawscott merged commit a745ca0 into kafkaex:master Oct 15, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ebert Ebert did not find any new or fixed issues.
Details

@skateinmars skateinmars deleted the skateinmars:readme-applications branch Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment