New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken example in the README.md #177

Merged
merged 1 commit into from Oct 16, 2016

Conversation

Projects
None yet
3 participants
@ddziaduch
Contributor

ddziaduch commented Oct 16, 2016

Hi!

The example in the README.md seems to be broken. I think I have fixed it :)

@jails

This comment has been minimized.

Show comment
Hide comment
@jails

jails Oct 16, 2016

Contributor

Good catch 👍 , can you open it on the dev branch instead plz ?

Contributor

jails commented Oct 16, 2016

Good catch 👍 , can you open it on the dev branch instead plz ?

@samsonasik samsonasik changed the base branch from master to dev Oct 16, 2016

@samsonasik

This comment has been minimized.

Show comment
Hide comment
@samsonasik

samsonasik Oct 16, 2016

Collaborator

I've changed the target branch to dev, seems mergeable now.

Collaborator

samsonasik commented Oct 16, 2016

I've changed the target branch to dev, seems mergeable now.

@ddziaduch

This comment has been minimized.

Show comment
Hide comment
@ddziaduch

ddziaduch Oct 16, 2016

Contributor

Ah sorry I missed that :(

Contributor

ddziaduch commented Oct 16, 2016

Ah sorry I missed that :(

@samsonasik samsonasik merged commit 1b23214 into kahlan:dev Oct 16, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.433%
Details
@samsonasik

This comment has been minimized.

Show comment
Hide comment
@samsonasik

samsonasik Oct 16, 2016

Collaborator

@ddziaduch nvm, I've changed the target branch to dev. merged. Thanks ;)

Collaborator

samsonasik commented Oct 16, 2016

@ddziaduch nvm, I've changed the target branch to dev. merged. Thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment