Repository navigation
web3Auth updated - #112
Merged
Merged
web3Auth updated#112
Conversation
ayo-klaytn
requested review from
aidan-kwon,
blukat29,
kjeom,
naveed-kaia,
praveen-kaia and
scott-klaytn
as code owners
September 22, 2024 16:00
scott-klaytn
approved these changes
Sep 23, 2024
kjeom
reviewed
Sep 23, 2024
kjeom
reviewed
Sep 23, 2024
|
|
||
| } | ||
|
|
||
| const writeToContract = async (provider: IProvider, value : string): Promise<any> => { |
Collaborator
There was a problem hiding this comment.
How do you think about the function name to be the "action". I think the "writeToContract" is too general.
Collaborator
There was a problem hiding this comment.
I personally prefer the function name like "storeNumToContract". I think it's good if you are ok because it's very minor thing.
| } | ||
| }; | ||
|
|
||
| const readFromContract = async (provider: IProvider): Promise<string> => { |
Collaborator
There was a problem hiding this comment.
Same with the writeToContract function name.
Collaborator
There was a problem hiding this comment.
In this case, "getNumFromContract" looks better
kjeom
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
updates web3Auth guide
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to reach out. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLAin first time contributeRelated issues
Further comments
If this is a relatively large content contribution, kick off the discussion by explaining why you would suggest the content contribution, etc...