Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface bug #130

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Interface bug #130

merged 6 commits into from
Jul 1, 2024

Conversation

kaipartmann
Copy link
Owner

See #119.

@kaipartmann kaipartmann added the bug Something isn't working label Jun 28, 2024
@kaipartmann kaipartmann added this to the v0.3.0 milestone Jun 28, 2024
@kaipartmann kaipartmann linked an issue Jun 28, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 97.27626% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.24%. Comparing base (91849e4) to head (5cd3e6c).

Files Patch % Lines
src/core/storages.jl 78.94% 4 Missing ⚠️
src/physics/continuum_kinematics_inspired.jl 98.13% 2 Missing ⚠️
src/discretization/interaction_system.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   89.17%   89.24%   +0.06%     
==========================================
  Files          44       44              
  Lines        3677     3831     +154     
==========================================
+ Hits         3279     3419     +140     
- Misses        398      412      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaipartmann kaipartmann marked this pull request as ready for review June 30, 2024 01:17
@kaipartmann
Copy link
Owner Author

The interfaces may also be considered for the calculation of the energy based surface correction.

@kaipartmann kaipartmann merged commit 9126819 into main Jul 1, 2024
8 checks passed
@kaipartmann kaipartmann deleted the interfaces_bug branch July 1, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interfaces
1 participant