Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add a note on how to set a hardcoded k3s node name #1244

Merged
merged 2 commits into from
Apr 4, 2023
Merged

📖 Add a note on how to set a hardcoded k3s node name #1244

merged 2 commits into from
Apr 4, 2023

Conversation

jimmykarily
Copy link
Contributor

Fixes #576

@jimmykarily
Add a note on how to set a hardcoded k3s node name
d9001bd 
Fixes #576

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily jimmykarily self-assigned this Apr 3, 2023
@netlify
Copy link

netlify bot commented Apr 3, 2023 •
edited
Loading

✅ Deploy Preview for kairos-io ready!

Name Link
🔨 Latest commit 1c3c632
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/642ae0b234ba2c0007c19e54
😎 Deploy Preview https://deploy-preview-1244--kairos-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jimmykarily jimmykarily added the documentation Improvements or additions to documentation label Apr 3, 2023
@jimmykarily jimmykarily mentioned this pull request Apr 3, 2023
Closed
@jimmykarily
Convert parenthesis to an "alert"
1c3c632 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
mauromorales
mauromorales approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 😎

mudler
mudler approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@mudler mudler changed the title Add a note on how to set a hardcoded k3s node name 📖 Add a note on how to set a hardcoded k3s node name Apr 4, 2023
@mudler mudler merged commit 4c332a6 into master Apr 4, 2023
@mudler mudler deleted the 576-document-stubbed-node-name branch April 4, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromorales mauromorales mauromorales approved these changes

@mudler mudler mudler approved these changes

Assignees

@jimmykarily jimmykarily

Labels
documentation Improvements or additions to documentation
Projects
🧙Issue tracking board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📖 k3s node name is different from hostname
3 participants
@jimmykarily @mauromorales @mudler