Implement "previous commit messages" #9

Closed
kaisellgren opened this Issue Apr 28, 2012 · 4 comments

2 participants

@kaisellgren
Owner

Implement "previous commit messages".

Currently there's a button "Copy Message", consider renaming it to something better. It should provide a popup menu upon clicking (I suppose you need to assign Button.ContextMenu), and the popup would contain last X number of commit messages.

I believe it makes most sense to save those messages per repository. We could save those messages to a "commit-messages" file where Git-GUI is running in a JSON format (http://msdn.microsoft.com/en-us/library/bb292287). This information should be grouped by repository path (so that the messages are per repository).

When selecting one of the context menu entries, overwrite the commit message with the selected message. I think the context menu should crop the text because it can contain several line breaks and be big. So maybe display the first line of text directly as is?

Limit the number of past messages to 10 (at least for starters).

@kaisellgren kaisellgren was assigned Apr 28, 2012
@stanpalatnik stanpalatnik was assigned May 13, 2012
@stanpalatnik stanpalatnik added a commit that referenced this issue May 27, 2012
@stanpalatnik stanpalatnik Started working on Issue #9. So far, laid down boilerplate code for t…
…he popup and button event handling.
58aaf93
@stanpalatnik stanpalatnik added a commit that referenced this issue Jun 2, 2012
@stanpalatnik stanpalatnik Working on Issue #9. Added new model class for storing recent commit …
…messages. Created converter for the combobox to use(to read the property in the model). Renamed combobox.
159492e
@kaisellgren
Owner

It keeps committing when I keep pressing the commit button. It also has to check that there are some changes to commit.

The drop down should have a text such as "Copy a message" on top of it, otherwise it's confusing.

@stanpalatnik
Collaborator

Yea the drop down should have a default text. I'll add that.

"It keeps committing when I keep pressing the commit button."

I don't see how that's related to this issue.

@kaisellgren
Owner

I don't see how that's related to this issue.

Oh yes, wrong ticket.

@kaisellgren kaisellgren was assigned Jun 10, 2012
@kaisellgren
Owner

I finished this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment