Merged
Conversation
Contributor
Author
|
Forgot to include an example, I made this to parse the image response from my scanner, so here is an example response from my scanner: https://d.sijisu.eu/scanner.dump Works great in the Kaitai Web IDE |
KOLANICH
reviewed
Jan 28, 2021
Member
Thanks for the sample. I'm also uploading it GZIPped here on GitHub so that it stays available best forever: scanner.dump.gz |
KOLANICH
reviewed
Jan 28, 2021
generalmimon
requested changes
Jan 28, 2021
KOLANICH
reviewed
Jan 29, 2021
Co-authored-by: Petr Pučil <petr.pucil@seznam.cz>
Co-authored-by: Petr Pučil <petr.pucil@seznam.cz>
…ruct_formats into sijisu/add-dime_message
Co-authored-by: Petr Pučil <petr.pucil@seznam.cz>
Co-authored-by: Petr Pučil <petr.pucil@seznam.cz>
generalmimon
approved these changes
Feb 2, 2021
Member
generalmimon
left a comment
generalmimon
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the contribution!
Contributor
Author
|
Thank you for the help and reviews, guys! |
ZetaTwo
pushed a commit
to ZetaTwo/kaitai_struct_formats
that referenced
this pull request
May 17, 2022
* Added DIME message * Resolving requested changes * More expresive padding size definition * Made doc strings one-line * Changing padding id to avoid name collision * Fixed indentation * Simplify padding size Co-authored-by: Petr Pučil <petr.pucil@seznam.cz> * Include sample file Co-authored-by: Petr Pučil <petr.pucil@seznam.cz> * Spelling * Added file extension and mime type Co-authored-by: Petr Pučil <petr.pucil@seznam.cz> * Added options_field structure * Link directly to the ietf.org * Doc strings clarity * ID and type as strings * More doc strings * Updated sample file Co-authored-by: Petr Pučil <petr.pucil@seznam.cz> Co-authored-by: Petr Pučil <petr.pucil@seznam.cz>
ZetaTwo
pushed a commit
to ZetaTwo/kaitai_struct_formats
that referenced
this pull request
May 17, 2022
* Added DIME message * Resolving requested changes * More expresive padding size definition * Made doc strings one-line * Changing padding id to avoid name collision * Fixed indentation * Simplify padding size Co-authored-by: Petr Pučil <petr.pucil@seznam.cz> * Include sample file Co-authored-by: Petr Pučil <petr.pucil@seznam.cz> * Spelling * Added file extension and mime type Co-authored-by: Petr Pučil <petr.pucil@seznam.cz> * Added options_field structure * Link directly to the ietf.org * Doc strings clarity * ID and type as strings * More doc strings * Updated sample file Co-authored-by: Petr Pučil <petr.pucil@seznam.cz> Co-authored-by: Petr Pučil <petr.pucil@seznam.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the old-school DIME (Direct Internet Message Encapsulation) format. Based on the 2002 Microsoft draft here.
I was unsure on the folder where to put it, but settled on
network/.Thanks for this awesome project!