Removed Travis automation, added GH Actions build & publish to npm #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generalmimon
reviewed
May 4, 2020
generalmimon
reviewed
May 4, 2020
generalmimon
approved these changes
May 4, 2020
Member
generalmimon
left a comment
generalmimon
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge it.
Member
Author
|
Ok, the most interesting part, i.e. publication, actually failed: https://github.com/kaitai-io/kaitai_struct_javascript_runtime/runs/644104474?check_suite_focus=true I need to double check if that method of supplying the auth token is correct. |
generalmimon
reviewed
May 4, 2020
| - name: Publish to npm | ||
| run: npm publish --tag next | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{secrets.npm_token}} |
Member
There was a problem hiding this comment.
I need to double check if that method of supplying the auth token is correct.
@GreyCat Yeah, it obviously can't work, because your secret is called NODE_AUTH_TOKEN, not npm_token. So it should be probably ${{ secrets.NODE_AUTH_TOKEN }}.
Member
Author
There was a problem hiding this comment.
Got it, thanks! Fixed, let's try it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.