-
Notifications
You must be signed in to change notification settings - Fork 31
Add API_VERSION constant storing the runtime version as a tuple of ints #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since this topic came up again in #62 - any objections to merging this (followed by kaitai-io/kaitai_struct_compiler#208)? I don't remember all of the details of the long discussion in kaitai-io/kaitai_struct#804, but IIRC there were no strong objections to this solution. |
Actually, I need to update this first to bump all of the version numbers. I created this PR before the release of KS 0.9, so all of the comments still say 0.9 and not 0.10. |
IMHO the symbol should either start with underscore or have |
Why do you think the name should be changed this way? An underscore would be misleading.
I don't think we can do that. The |
f28fc4b
to
2ea0df0
Compare
Rebased on top of #64 to update the Kaitai Struct version number. |
I am not sure it does it statically, for static extraction there is |
setuptools 46.4.0 and later will parse attribute values statically if possible. If that fails, it still falls back to importing the module, but I would like to avoid that if possible. |
2ea0df0
to
90f4806
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgelessus LGTM, thanks!
Part of one of the potential fixes for kaitai-io/kaitai_struct#804.