Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@content not allowed in global context #112

Closed
Keats opened this issue Jun 1, 2021 · 4 comments
Closed

@content not allowed in global context #112

Keats opened this issue Jun 1, 2021 · 4 comments

Comments

@Keats
Copy link

Keats commented Jun 1, 2021

From trying to compile bootstrap 5.0.1

Is it possible to have spanned errors or is it too complex? Right now it just prints the error message but there are many @content use in the whole bootstrap codebase.

@kaj
Copy link
Owner

kaj commented Jun 2, 2021

Some errors (mainly errors in function calls) are spanned, and the plan is to have that in more places. Perhaps mixins and @content should be next.

@kaj
Copy link
Owner

kaj commented Jun 2, 2021

Also, just looking at the code, I think there is a problem with the condition causing that error. Actually, it might be most correct to just remove it. :-)

@kaj kaj closed this as completed in cdb1484 Jun 2, 2021
kaj added a commit that referenced this issue Jun 2, 2021
Better handling of mixin call bodies, the `@content` item, and the
`content_exists` function.

Fixes #112.
kaj added a commit that referenced this issue Jun 2, 2021
Better handling of mixin call bodies, the `@content` item, and the
`content_exists` function.

Fixes #112.
@Keats
Copy link
Author

Keats commented Jun 2, 2021

Sweet thanks. Do you want me to report the bootstrap issues or is too much noise? I figure once rsass can compile bootstrap and some various sites I have lying around I can probably switch Zola from sass-sys to rsass which is pretty exciting!

@kaj
Copy link
Owner

kaj commented Jun 2, 2021

Keep them coming! 😎 As long as they are somewhat researched and not too many at the same time, they are a valuable help in getting rsass better!

Also, having something as good as Zola use rsass would be avesome! Though there is some use of @extend (see #65) in bootstrap, so I fear it will take some time getting there.

kaj added a commit that referenced this issue Jun 20, 2021
Progress: 3992 of 6180 tests passed in dart-sass compatibility mode.

* The `sass::Item::MixinCall` enum alternative was modified.
* Signature changes in `css::CallArgs` and `sass:CallArgs`,
  and new alternatives in `sass::ArgsError`.
* `css::Value` has a new variant `ArgList`.
* The `OrderMap::keys()` and `values()` functions now returns iterators,
  `OrderMap::remove(key)` now returns the removed value.

* Better handling of mixin call bodies, the `@content` item, and the
  `content_exists` function.  Fixes #112.
* `@import` exposes things `@forward`ed in the imported module.
* Many improvements in parameter passing to functions and mixins.  PR #113.
* Some more fixes regarding function calls and modules.
* Support the `keywords` function in `sass:meta`.
* Removed some debug printouts that was accidentally left in 0.21.0.
* Update sass-spec test suite to 2021-06-14.

Thanks to @Keats for reporting #112 and #108.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants