Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
really love the extension so far.
One thing that bugs me (a little) is that you basically have to set the advantage to "always ask" in order to react to all kinds of situations.
It would be much easier if you could do something like adding another button next to the beyond20 button for rolling, one for a normal roll, one for advantage roll, one for disadvantage roll, etc.
Alternatively, something like holding shift/control/alt while clicking the button could lead to different rolls.
Or right-clicking the roll-button (not sure if that is doable, might be a bit intrusive).
The idea of having the modifers with Shift/Control/Alt is great and will definitely be adding that. I'll need to find a way to make it obvious because rare are those who read the documentation! Perhaps a tooltip would be enough.
I agree modifier keys are better.
Many methods here to convey that something is happening, but I don't know if some of them wouldn't be too much.
In the end, when it comes to modifier keys, you'll never be able to make it perfectly clear and obvious to everyone all the time. Not even high-profile games manage to do that.
I think it would be a bigger issue if the only way to do advantage was with modifiers, but most people will still just the options from the quick settings menu. Having the modifiers is just a little plus.
Since I'm an impatient guy (and wanted this for an upcoming session), I just went ahead and created a completely bare-bones variant of this for myself in a few minutes.
Adding this near the top of dndbeyond.pyj:
And this in def sendRoll in the same file (after the advantage is read from settings):
As I said, totally bare-bones, no changes to buttons or anything. Just advantage on Ctrl and Disadvantage on Shift. But it does work.