Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for special features #9

Closed
kakaroto opened this issue May 20, 2019 · 12 comments
Closed

Support for special features #9

kakaroto opened this issue May 20, 2019 · 12 comments
Labels

Comments

@kakaroto
Copy link
Owner

@kakaroto kakaroto commented May 20, 2019

This issue is to track the special features that need to be supported:

  • Sneak attack: Done
  • Disciple of Life: Done
  • Jack of all trades on raw abilities : Done
  • Sharpshooter and Great weapon master: Done
  • Improved/Superior Critical : Done
  • Brutal critical: Done
  • Savage Attacks: Done
  • Rage damage: Done
  • Great Weapon Fighting: DONE
  • Blood Hunter's Crisom Rite: DONE
  • Hex Blade's curse critical threshold : DONE
  • Oath of heroism critical threshold: DONE
  • Dread Ambusher extra damage for Ranger Gloomstalker : DONE
  • Rogue's Assassinate: DONE

TODO:

  • Elven Accuracy: TODO (Display separate roll ?)
kakaroto added a commit that referenced this issue May 21, 2019
… and Disciple of Life

Disciple of Life is now only available as an option if you have it as a class feature,
it's not available to all clerics anymore.
Features are stored and fetched automatically, but are only updated if the
features & traits pane is opened

Affects #9
@kakaroto

This comment has been minimized.

Copy link
Owner Author

@kakaroto kakaroto commented May 22, 2019

Added Improved Crticial and Brutal Critical to the list

kakaroto added a commit that referenced this issue May 26, 2019
Affects #9
Also avoids invalid critical hit/miss on custom dice rolls.
kakaroto added a commit that referenced this issue May 27, 2019
kakaroto added a commit that referenced this issue May 29, 2019
@jekface

This comment has been minimized.

Copy link

@jekface jekface commented Jun 2, 2019

Hi, first of all, awesome job! Found an issue I think might need some work. Monk special skill for deflecting missiles. The roll is supposed to add Dex and monk level. It just rolls the d10 without bonuses. Anyway, thanks for this extension. Great job!! I love it.

@kakaroto

This comment has been minimized.

Copy link
Owner Author

@kakaroto kakaroto commented Jun 3, 2019

Cool thanks for letting me know, I'll add support for it!

kakaroto added a commit that referenced this issue Jun 7, 2019
This helps with #9 by adding support for Deflect Missiles and Second Wind
so it sends the ability modifier and class level as part of the dice formula.
Since the regexp was changed, this NEEDS TESTING!
@kakaroto

This comment has been minimized.

Copy link
Owner Author

@kakaroto kakaroto commented Jun 7, 2019

Deflect Missiles should work now (only if clicked from D&D Beyond, not from within the roll20 description). Same with other features that have "+ your modifier" or "+ your level", such as Second Wind.

@further-reading

This comment has been minimized.

Copy link

@further-reading further-reading commented Jun 9, 2019

Hey man, I love this extension! I've been working on my own version but yours blows all my work out of the water.

Had some issues though today when using it with my monk:

  • Monk unarmed attacks seem to use the static default damage instead of their special damage die.
  • There doesn't seem to be a way to roll tool use - I expect this is because the dndbeyond card doesn't give the roll info.
@kakaroto

This comment has been minimized.

Copy link
Owner Author

@kakaroto kakaroto commented Jun 9, 2019

@further-reading hey thanks! I just saw your dndbeyond scraper. I don't know if you're aware, but you can take any character URL in D&D Beyond and add '/json' to the URL to get the full character sheet in a json format! It might be easier than trying to parse the html :)

1 - I'm not sure about that. I can see that D&D Beyond already shows the unarmed attack as 1d4 + DEX in the case of my monk character and the right dice is rolled. Normally it would be 1 + STR.
2 - Yeah, that's a D&D Beyond issue, What I do is create a custom skill for any tools, like Thieve's tools for example, Beyond20 already supports it and if you don't specify the ability for the custom skill, it will query it in the R20 window.

@further-reading

This comment has been minimized.

Copy link

@further-reading further-reading commented Jun 10, 2019

Oh wow, that's a great fix for the tools proficiency issue!

For my Monk I had a another test and it seems to be something to do with the custom damage option. Before I used it the roll worked properly but then after it was set it stopped rolling my Monk damage die. My Monk also has a negative strength modifier which might have impacted it too(it'd make the default damage 0)? Character sheet is here if you wanna try https://www.dndbeyond.com/profile/Further_Reading/characters/10371377

As an aside about the scraper, I know about the json but a main reason behind it is practice - I like to learn new techniques by using them to make something in my life easier so this seemed like a fun way to learn webscraping! :P

kakaroto added a commit that referenced this issue Jun 10, 2019
Custom damage bonus was replacing the actual damage for action panes.
Reported by @further-reading in #9
@kakaroto

This comment has been minimized.

Copy link
Owner Author

@kakaroto kakaroto commented Jun 10, 2019

Oh you're right, my bad! it was fine for attacks and spells but for 'actions' I had it set to replace the damage instead of appending to it. All fixed now.
For the scraper, I figured as much considering the project description/README, but thought it was worth mentioning. I think it's a great project idea to get some practice!

@kakaroto

This comment has been minimized.

Copy link
Owner Author

@kakaroto kakaroto commented Jun 25, 2019

Add Great Weapon Fighting. Reroll on a 1 or 2 on two-handed weapons. R20 uses '1d8ro<2' to do the re-roll once.

@SANSd20

This comment has been minimized.

Copy link

@SANSd20 SANSd20 commented Jun 27, 2019

Also, how about Elven Accuracy? Most for the "Whenever you have advantage on an attack roll using Dexterity, Intelligence, Wisdom, or Charisma, you can reroll one of the dice once."

@kakaroto

This comment has been minimized.

Copy link
Owner Author

@kakaroto kakaroto commented Jul 1, 2019

I'm trying to add Elven Accuracy, but it's a though one because D&D Beyond doesn't tell me what the ability is when you do an attack, so I'd have to add a lot of logic into the extension itself to determine if dexterity is used for weapons or strength, or what class a spell is coming from and what ability is used for attack for that class to determine if Elven Accuracy would count. Also, it would only work if you select "roll with advantage", if you use "always roll twice" then should I also do it ? Also, Roll20 doesn't allow to specify more than 2 rolls for attack. Lucky feat is similar too I guess, though you make the decision after you roll.
I'll leave it for now in the list of special things to handle, but I'm not making it a priority. In those cases, I think it makes more sense to determine in advance with the DM that the damages from the first roll are to be used and to re-roll only to get the additional 'to-hit' result and ignore the rest.

kakaroto added a commit that referenced this issue Sep 15, 2019
kakaroto added a commit that referenced this issue Nov 20, 2019
Also fix the bloodhunter class level detection
Enable disciple of life by default
Affects #9
kakaroto added a commit that referenced this issue Nov 20, 2019
kakaroto added a commit that referenced this issue Nov 20, 2019
kakaroto added a commit that referenced this issue Nov 20, 2019
kakaroto added a commit that referenced this issue Nov 20, 2019
@kakaroto

This comment has been minimized.

Copy link
Owner Author

@kakaroto kakaroto commented Dec 4, 2019

Closing this issue at this point. Future special features should get their own issues created

@kakaroto kakaroto closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.