New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix customCSS, and update exampleSite #200

Merged
merged 4 commits into from Sep 18, 2017

Conversation

Projects
None yet
2 participants
@dojineko
Copy link
Contributor

dojineko commented Sep 18, 2017

fix customCSS logic, and update example project.

@@ -12,7 +12,7 @@
# For developpers, if you modify this theme, put your images in `source/images` folder and
# use grunt task `build` to synchronize assets

baseurl = ""
baseURL = "https://example.org/"

This comment has been minimized.

@kakawait

kakawait Sep 18, 2017

Owner

Any reason to change baseURL?

This comment has been minimized.

@dojineko

dojineko Sep 18, 2017

Contributor

because, official parameter name is baseURL
https://gohugo.io/getting-started/configuration/#yaml-configuration

ERROR ***** No 'baseURL' set in configuration or as a flag. Features like page menus will not work without one.

but, it seemed to work even in baseurl.

@kakawait kakawait self-assigned this Sep 18, 2017

@kakawait kakawait added the bug label Sep 18, 2017

@kakawait kakawait changed the base branch from master to develop Sep 18, 2017

@kakawait kakawait added this to the 0.4.2-BETA milestone Sep 18, 2017

@kakawait kakawait merged commit 47de9ae into kakawait:develop Sep 18, 2017

@dojineko dojineko deleted the dojineko:fix-custom-css branch Sep 18, 2017

@dojineko

This comment has been minimized.

Copy link
Contributor

dojineko commented Sep 18, 2017

@kakawait thanks!

@kakawait

This comment has been minimized.

Copy link
Owner

kakawait commented Sep 18, 2017

@dojineko be careful is actually only on develop branch, I have to release new release to get it on master

I use to release on sunday

@dojineko

This comment has been minimized.

Copy link
Contributor

dojineko commented Sep 18, 2017

@kakawait okay!

zacbook pushed a commit to zacbook/hugo-tranquilpeak-theme that referenced this pull request Nov 12, 2017

Merge pull request kakawait#200 from dojineko/fix-custom-css
Fix customCSS, and update exampleSite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment