Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swappable pagination buttons by configulation #202

Merged
merged 4 commits into from Oct 13, 2017

Conversation

@dojineko
Copy link
Contributor

@dojineko dojineko commented Sep 18, 2017

adjust to original hexo tranquilpeak theme
ref: hexo's demo page

add swapPaginator option to configulation.
default pagenator looks like < NEXT | PREV >
image

If set this value to true, it looks like < PREV | NEXT >
(it seems general UI design, hexo's one, google, amazon etc,etc...)
image

updated: 2017-09-23

@kakawait
Copy link
Owner

@kakawait kakawait commented Sep 18, 2017

@dojineko Already discussed on past (see #118) I think I will not change it again because I will be infinite loop request.

But we can imagine a configuration to enable to switch. Personally I prefer the current (this theme not Hexo original) version.

@dojineko
Copy link
Contributor Author

@dojineko dojineko commented Sep 18, 2017

@kakawait
oops, i understood. i make it changeable by configuration.

@dojineko dojineko changed the base branch from master to develop Sep 18, 2017
@dojineko dojineko force-pushed the dojineko:swap-pagination-buttons branch from 5c35595 to bbe13ad Sep 18, 2017
@dojineko dojineko changed the title Swap pagination buttons Swappable pagination buttons by configulation Sep 18, 2017
@dojineko
Copy link
Contributor Author

@dojineko dojineko commented Sep 18, 2017

@kakawait updated! plz check this later :)

@dojineko dojineko force-pushed the dojineko:swap-pagination-buttons branch from bbe13ad to 1ef22ae Sep 18, 2017
@dojineko dojineko force-pushed the dojineko:swap-pagination-buttons branch from 7a742ad to e7d3ef5 Sep 23, 2017
@kakawait
Copy link
Owner

@kakawait kakawait commented Sep 23, 2017

Thank for contribution I will check that tomorrow, sorry for delay

@@ -172,6 +172,10 @@ canonifyurls = true
# they have to be referred from static root. Example
# customJS = ["js/foo.js"]

# Display `Next` on left side of the pagination, and `Prev` on right side one.
# If you set this value to `true`, these positions swap.
# swapPagenator = true

This comment has been minimized.

@kakawait

kakawait Oct 2, 2017
Owner

Do you mean swaPaginator instead pagenator?

This comment has been minimized.

@dojineko

dojineko Oct 7, 2017
Author Contributor

fixed!

@kakawait
Copy link
Owner

@kakawait kakawait commented Oct 13, 2017

I was very busy sorry for delay. Thank you for your contribution

@kakawait kakawait merged commit e0b7043 into kakawait:develop Oct 13, 2017
@dojineko dojineko deleted the dojineko:swap-pagination-buttons branch Oct 13, 2017
@kakawait kakawait added this to the 0.4.2-BETA milestone Nov 1, 2017
zacbook pushed a commit to zacbook/hugo-tranquilpeak-theme that referenced this pull request Nov 12, 2017
Swappable pagination buttons by configulation
@yamila-moreno
Copy link
Contributor

@yamila-moreno yamila-moreno commented Sep 15, 2018

Hi! is this feature still working? I'm using both "true" and "false" swapPaginator but it always enters in the "else" part. I tried to print the value {{ .Site.Params.swapPaginator }} but I didn't see anything, which is expected if the value is not accessed.

On regard of this value, I suggest to change the config.toml commented documentation from "true" to "false", because "false" is the default value; I believe that the commented code is expected to be the default (so uncommenting that line woudn't change behaviour).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants