New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other shells on Windows besides `cmd.exe` #1475

Closed
jsibley2 opened this Issue Jul 21, 2016 · 9 comments

Comments

Projects
None yet
2 participants
@jsibley2

jsibley2 commented Jul 21, 2016

Please complete the following steps. The more steps you complete the more
likely we are to address your issue!

  1. Please review the current list of issues to make sure you are not submitting a duplicate.
  2. Please tag your issue appropriately. Please review the tagging criteria.
  3. Based on the issue type tag selected above please fill in the relevant section below.

Bug Report

Tell us about your setup

What is your Kalabox version and operating system?
Beta 2 (downloaded from github on 7/21/16) on Windows 10 Home

Example: v0.12.0-beta1 on Windows 8.1 Professional

Have you previously installed Kalabox? If so, what version?
Had previous installed and removed alpha version (not sure which release)

Tell us about your bug

kbox up gives this error messages in terminal window:

$ kbox up
Unhandled rejection VError: Error bringing machine up.: Failed after 5 retries. {"max":5,"backoff":500}: EINVAL, invalid argument
at C:\Program Files\Kalabox\bin\plugins\kalabox-engine-docker\provider\docke r\machine.js.jx:74:13

It appears that the plugins directory is under Kalabox and not under Kalabox\bin

Virtualbox manager is installed and I can start Kalabox2 from there. I'm not sure whether this is anything else to test after that.

Please detail the steps we can take to replicate this bug. Be as detailed as possible.

  1. Started terminal (git bash)
  2. cd .. (to get to c:\Users)
  3. kbox up
  4. Error as above

Just typing kbox gives me:

Usage: kbox.exe [-- ]

Does this bug prevent you from using Kalabox?
Yes

@pirog

This comment has been minimized.

Member

pirog commented Jul 21, 2016

do you get the same behavior using cmd.exe instead of git bash?

@jsibley2

This comment has been minimized.

jsibley2 commented Jul 21, 2016

Thank you. I needed to use the Windows command prompt.

Now:
kbox gives me a list of commands
kbox up seems to work
kbox create pantheon gives me the prompts and I get through the prompts, then get:
Creating.
Cleaning up.
Creating app structure.
undefined
undefined

@pirog

This comment has been minimized.

Member

pirog commented Jul 21, 2016

@jsibley2 can you open a separate issue for that? im going to change this to a feature request to support other shells beyond cmd.exe

@pirog pirog changed the title from Beta 2 installation problems to Support other shells on Windows besides `cmd.exe` Jul 21, 2016

@pirog

This comment has been minimized.

Member

pirog commented Jul 21, 2016

also it might be useful to run that command again with the debug flag so you can get some more feedback on the issue you are having

kbox create pantheon -- -d

@pirog pirog added the feature label Jul 25, 2016

@pirog pirog added this to the v0.13.0-beta.4 milestone Jul 29, 2016

@pirog pirog self-assigned this Jul 29, 2016

@pirog

This comment has been minimized.

Member

pirog commented Aug 3, 2016

@jsibley2 so i am investigating this a little more and it looks like generally CYGWIN/MINGW64 shells don't play nice with Node (which is the language we write kalabox in)
nodejs/node#3006

It looks like there are some workaround there though. I'm going to try a new other popular Windows shells out and see how they work. Either way i hope to provide greater support or at least recommend a shell for people to use.

@pirog

This comment has been minimized.

Member

pirog commented Aug 3, 2016

Yeah @jsibley2, i think doing anything here is going to be a non-trivial amount of effort so i am going to bump the estimate here and move to the next sprint.

@pirog pirog modified the milestones: v0.13.0-beta.5, v0.13.0-beta.4 Aug 3, 2016

@jsibley2

This comment has been minimized.

jsibley2 commented Aug 3, 2016

Not an issue for me, really. I'm fine with command.exe, just didn't know I had to use it.

@pirog

This comment has been minimized.

Member

pirog commented Aug 3, 2016

@jsibley2 good to hear. I suspect other people are the same which is why im going to backlog this issue and save it for a rainy day. I will at least update our docs to make cmd.exe required.

pirog added a commit that referenced this issue Aug 3, 2016

@pirog pirog removed this from the v0.13.0-beta.5 milestone Aug 4, 2016

@pirog

This comment has been minimized.

Member

pirog commented Sep 14, 2016

Yeah AFAICT the facts in #1475 (comment) prevent us from supporting this

@pirog pirog closed this Sep 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment